Bug 397580 - Agent need to support several file formats
Summary: Agent need to support several file formats
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.1   Edit
Assignee: Didier Brachet CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-07 09:51 EST by Didier Brachet CLA
Modified: 2013-06-05 04:40 EDT (History)
0 users

See Also:


Attachments
proposed patch (35.72 KB, patch)
2013-01-07 09:53 EST, Didier Brachet CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Didier Brachet CLA 2013-01-07 09:51:09 EST
Build Identifier: 

Currently, the TCF agent is able to support only one file format at a time. Either ELF on Linux or PE or ELF on Windows. It would be useful to allow the agent to support several file format in the same debug session especially for cross debugging.

Reproducible: Always

Steps to Reproduce:
N/A
Comment 1 Didier Brachet CLA 2013-01-07 09:53:35 EST
Created attachment 225284 [details]
proposed patch

This is a proposed patch that adds support for a Symbol & Line number multiplexer. When not enabled; it has no impact on existing code.

This has been tested on Windows with a mix of PE & ELF symbol files.

Eugene, please let me know if you agree with the approach. If yes, I will complete the changes (fix build support in Visual project + some cleanup after more testing) and commit them. Thanks.
Comment 2 Eugene Tarassov CLA 2013-01-08 12:30:47 EST
(In reply to comment #1)
> Created attachment 225284 [details]
> proposed patch
> 
> This is a proposed patch that adds support for a Symbol & Line number
> multiplexer. When not enabled; it has no impact on existing code.
> 
> This has been tested on Windows with a mix of PE & ELF symbol files.
> 
> Eugene, please let me know if you agree with the approach. If yes, I will
> complete the changes (fix build support in Visual project + some cleanup
> after more testing) and commit them. Thanks.

The patch looks very good. I like the approach. Thanks!
Comment 3 Didier Brachet CLA 2013-01-16 11:06:25 EST
Patch committed with some modifications. Thanks for the review Eugene.