Bug 397371 - assertion in safe_skip_breakpoint should check the canonical address of the current PC
Summary: assertion in safe_skip_breakpoint should check the canonical address of the c...
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: 1.1   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-03 08:18 EST by Emmanuel Mising name CLA
Modified: 2013-06-05 04:40 EDT (History)
0 users

See Also:

Attachments
proposed patch (1.06 KB, application/octet-stream)
2013-01-03 08:18 EST, Emmanuel Mising name CLA 		eugene: iplog+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emmanuel Mising name CLA 2013-01-03 08:18:57 EST 
Created attachment 225172 [details]
proposed patch

in safe_skip_breakpoint the following assertion triggers if the canonical address of a bp was transformed:
assert(bi->cb.address == get_regs_PC(ctx));

To be consistent with the logic in skip_breakpoint, the assertion should compare the canonical address of the current PC.

A proposed patch is attached.
Comment 1 Eugene Tarassov CLA 2013-01-04 12:25:40 EST 
I have committed the patch.
Thanks!