Bug 397035 - Save button on edit page needs role
Summary: Save button on edit page needs role
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 2.0 M2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2012-12-20 15:58 EST by Carolyn MacLeod CLA
Modified: 2012-12-21 12:57 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2012-12-20 15:58:21 EST 
Orion build I20121219-2230

On the Edit page: https://orion.eclipse.org/edit/edit.html

The Save button:
<span tabindex="0" id="Save" class="commandButton">Save</span>

needs to have role="button".

Does it make any sense to use a <button> element for these? Then they would not need tabindex="0" or role="button" because they would get that for free. Would need to modify the css and js a bit to use <button>. Not sure if there are other advantages/disadvantages.
Comment 1 Susan McCourt CLA 2012-12-20 23:00:41 EST 
I thought we did this, I must have lost it in my refactoring.  The spans were used to get background images/sprites.
Comment 2 Susan McCourt CLA 2012-12-21 12:57:23 EST 
Missed a "button" role in commands.js during dojo/dijit refacotring.  Fixed in

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ebe9c8a4b250fd6b0a02efdc308e2e62156fd4f4

thanks for catching that, Carolyn.