Community
Participate
Working Groups
public class StringConcat { protected void concat(){ String s = "a"+"B"+"1" ; System.out.println(s); } } 1. Select the String <"a"+"B"+"1" > in the above code with the additional space 2. Invoke Quick Assist(Ctrl+1) Issue : 'Combine to single String' option is not available. The option reappears when the additional space is removed from the selection.
Billy, would you want to work on this?
Sure, I'll take this.
New Gerrit change created: https://git.eclipse.org/r/75288
Midhun, this results in test failures in AssistQuickFixTest.java. See the Gerrit build failure details here: https://hudson.eclipse.org/platform/job/eclipse.jdt.ui-Gerrit/841/
New Gerrit change created: https://git.eclipse.org/r/75312
Midhun, you should amend the existing Gerrit request to upload the new patch set instead of creating a new Gerrit request. I have abandoned the first one now. See: https://wiki.eclipse.org/EGit/User_Guide#Amending_Commits Review comments: - The new test case is not correct. It should check that the proposal exists now after your fix (#assertExpectedExistInProposals). - Do not add any additional whitespace in the patch. - Follow proper coding conventions. See: https://wiki.eclipse.org/JDT_UI/How_to_Contribute#Coding_Conventions Example: if statements always use braces {}. - In the fix, you are always using "fragmentList.get(0)". Even if I select the second fragment <"a" + "b" + "2" > in the following example, your fix will still convert the first fragment to single string: String s1 = "x" + "y" + "1" , s2 = "a" + "b" + "2" ; Try to look for a generic solution.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
