Bug 395563 - "Add to Index" command must not add derived resources
Summary: "Add to Index" command must not add derived resources
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: Core (show other bugs)
Version: 2.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-02 16:44 EST by Andrey Loskutov CLA
Modified: 2013-03-17 16:34 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2012-12-02 16:44:52 EST 
Using latest nightly 2.2.0 build. 
AS IS:
- Create two projects (in same parent directory), 
- Create a common repository for them from Eclipse. 
- Mark both projects in package Explorer and say "Team->Add to Index".
- Open stage view and see that all bin/*.class files and other resources from build directories of both projects are marked as "added".

TO BE:
Derived files should not be added to the index. In the last step staging view should not show *.class files and other resources from /bin directories.
Comment 1 Robin Rosenberg CLA 2013-01-07 18:36:19 EST 
Matthias, Robin: Leftovers from 359052
Comment 2 Matthias Sohn CLA 2013-01-08 10:40:36 EST 
First draft is here https://git.eclipse.org/r/#/c/8482/
but needs more work
Comment 3 Matthias Sohn CLA 2013-01-08 10:52:53 EST 
I suspect the proposed fix doesn't work because of timing issues since derived resources are usually generated by the build which runs asynchronously.

I started another approach trying to detect derived resources using a resource change listener to overcome this problem but this code doesn't work yet :-( 

I'll try to find time to try harder ;-)
Comment 4 Robin Rosenberg CLA 2013-01-23 13:38:38 EST 
Can we revert the "fix" that caused this mess?
Comment 5 Robin Rosenberg CLA 2013-01-23 13:40:16 EST 
i.e. 4a87652bde4f88327288a9cc02f3f4951fdf3aab
Comment 6 Robin Rosenberg CLA 2013-03-17 16:34:28 EDT 
https://git.eclipse.org/r/#/c/10269/ was merged in 2.3