Bug 394779 - [Performances] Do not open all nested editors at once
Summary: [Performances] Do not open all nested editors at once
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 1.0.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.0.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: Scalability
Keywords: plan
Depends on: 399874
Blocks: 394911 418010
  Show dependency tree
 
Reported: 2012-11-21 09:11 EST by Toni Siljamäki CLA
Modified: 2017-09-13 17:47 EDT (History)
3 users (show)

See Also:
cletavernier: luna+


Attachments
Reproducible test case. (389.76 KB, application/x-zip-compressed)
2012-11-21 09:11 EST, Toni Siljamäki CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toni Siljamäki CLA 2012-11-21 09:11:21 EST
Created attachment 223807 [details]
Reproducible test case.

There is no point in opening all diagrams in a model at once,
and especially not when a model has been split into parts.
What about "lazy loading" ?
How is it affected when all diagrams are opened?
This should be investigated.

Attached is a ws with proj backup and ppt slide.
Comment 1 Sébastien Gérard CLA 2013-01-26 07:04:28 EST
Diagrams that are opened when you open a model are the one that was still open when you closed the model. Papyrus keeps the history of its configuration including which views (both diagrams and tables) was open when a model is closed.
Some users of Papyrus do want this feature. I will asked other Ericsson users to know their views on your proposal. One possiblity is to have preference dedicated to either save or not the configuration when closing a model.
Comment 2 Toni Siljamäki CLA 2013-02-13 10:42:55 EST
Some additional comments on this one:

It is OK to leave the tabs for the diagrams that were "open" when you
last closed the model, but it is not OK to open all diagrams again the
next time you open the model, that is, to load all diagram contents again.
(related to bugzilla 394911)

Then one can wonder where the "configuration history" should be stored,
and why a model is/were marked as "touched" as soon as you switch diagram.
(related to bugzilla 394775)

You then get/got this asterisk saying that the model was modified and
should be saved, and if you do save the model, all the files are saved. (?)
(that is, the .di, the .notation and the .uml file)

This "configuration history" should perhaps instead be stored in
the .project file or some other non-model-file.
Comment 3 Toni Siljamäki CLA 2013-02-14 07:20:04 EST
By "OK to leave the tabs" above I mean that it's OK to show the tabs but
not OK to load the model content / content of "hidden" diagrams which
are not currently shown, until the user choose to display the content.

This is against your presented Model loading policy saying
"Avoid unneeded model part loading".

For that reason this bugzilla can not be regarded as an "enhancement",
since the selected model loading policy for "needed" resources is buggy.
Comment 4 Camille Letavernier CLA 2013-03-15 05:38:19 EDT
I'm still unsure this is even possible, unless the diagrams themselves are Controlled.

In EMF, the Resource is a loading unit. But even if we put each diagram in a single resource, we will need to load that resource for retrieving the diagram name and type (Displayed in the Tab and in the ModelExplorer).

It might be interesting to duplicate this information, and store it in the *.di file, in the "available pages", so that we don't need to load the whole notation resource to get the diagram name and type.
Comment 5 Toni Siljamäki CLA 2013-03-22 06:35:17 EDT
There is no "Related to", so I added to "Depends on".
Comment 6 Camille Letavernier CLA 2014-03-07 07:44:42 EST
Because the main performance issue is related to the "nested editors" being loaded (And not the Model itself), I rename this task
Comment 7 Ansgar Radermacher CLA 2017-09-13 17:47:32 EDT
Lazy diagram opening has been implemented in the context of bug 519107