Bug 394775 - [Papyrus General] Users are asked to save unmodified models.
Summary: [Papyrus General] Users are asked to save unmodified models.
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 1.0.0   Edit
Assignee: Camille Letavernier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 400809 403432 421411
Blocks: 459553 459556 459702
  Show dependency tree
 
Reported: 2012-11-21 08:50 EST by Toni Siljamäki CLA
Modified: 2015-02-11 12:04 EST (History)
3 users (show)

See Also:
sebastien.gerard: kepler+

Attachments
Reproducable test cases (764.89 KB, application/x-zip-compressed)
2012-11-21 08:50 EST, Toni Siljamäki CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Toni Siljamäki CLA 2012-11-21 08:50:08 EST 
Created attachment 223805 [details]
Reproducable test cases

Not mark a model as "modified" just because you switch to another diagram.
You know that you haven't modified the model, but a user can not be sure about it.
So... You are asked to save this unmodified model, and thereby creating a new version of it. (new timestamp)
The problem is the same in Indigo and Juno versions of Papyrus.

Attached are workspaces with backup projects in them, plus a ppt slide.
Comment 1 Toni Siljamäki CLA 2013-02-14 09:45:27 EST 
In the sprint planning presentation 11-Feb you refer to Bug 398712.

This one is also related to the newly submitted Bug 400809.
The "modified model" indication also happens when you open a
new diagram or close a diagram, when you stack diagram windows etc.

According to Bug 400809:
Such private user information should not even be stored in the model.
Comment 2 Camille Letavernier CLA 2013-03-15 06:14:00 EDT 
Current status:

- Opening/Closing a page (Table, Diagram, ...): Marks the model as dirty. Related to Bug 400809.
- Switching tab: Does not mark the model as dirty anymore.
- Manipulating empty tables: Model is dirty. It can be saved, but will remain dirty. This is a bug from the Tables, where a new command is triggered after each save action. I think this is an EMF Facet bug. However, this is a deprecated component and it probably won't be fixed. Closing the empty table (Or adding elements in the table) will fix the issue.
- Opening SysML Diagrams: there seems to be a "version migration" when SysML IBD diagrams are opened, which marks the model as dirty. The migration action is always executed, while it should probably be executed only once. I will open a specific bug for this one.

There may still be a few actions which mark the editor as dirty whereas they should not. They need to be identified.
Comment 3 Toni Siljamäki CLA 2013-06-19 13:14:41 EDT 
I have tested this in Kepler RC4.
Switching to another diagram does not "touch" the model. (= need to save it)
...but closing a diagram or opening one do!

This problem is described in Bug 400809.
...and this is related to the 3-file Papyrus model discussed recently.
Comment 4 Camille Letavernier CLA 2014-03-11 11:09:31 EDT 
> I have tested this in Kepler RC4.
> Switching to another diagram does not "touch" the model. (= need to save it)
> ...but closing a diagram or opening one do!
> 
> This problem is described in Bug 400809.
> ...and this is related to the 3-file Papyrus model discussed recently.

This is now fixed (Details in Bug 429239). 

I leave this bug opened because of subtask Bug 403432
Comment 5 Toni Siljamäki CLA 2014-03-11 15:11:47 EDT 
..and still open because of Bug 421411.
Comment 6 Camille Letavernier CLA 2014-08-01 08:55:32 EDT 
Remaining subtasks have been fixed