Bug 392926 - [performance] persistence.xml editor tabs should not be built until selected
Summary: [performance] persistence.xml editor tabs should not be built until selected
Status: RESOLVED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: JPA (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M3   Edit
Assignee: Karen Butzke CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2012-10-26 11:42 EDT by Karen Butzke CLA
Modified: 2012-11-02 14:19 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2012-10-26 11:42:50 EDT 
The persistence.xml editor should take advantage of the FormEditor's behavior and not build the contents of the tabs until they are selected. Building them when the persistence.xml is shown makes it slower to build, uses more SWT handles than necessary, and leads to potential leaks since the we have to dispose of those widgets manually.
Comment 1 Karen Butzke CLA 2012-11-02 14:19:52 EDT 
Some provisional API was changed to fix this bug:

renamed JpaPageComposite to JpaEditorPageDefinition and it no longer extends JpaCOmposite. Added the method buildEditorPageContent(...) which is called when the particular tab is selected in the editor.