Bug 392124 - Add view filter that filters types as defined on the 'Type Filters' preference page
Summary: Add view filter that filters types as defined on the 'Type Filters' preferenc...
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.3   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2012-10-16 17:45 EDT by Alex Blewitt CLA
Modified: 2012-10-17 03:31 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2012-10-16 17:45:32 EDT 
When using the Java Browsing perspective, the Packages view can show the list of packages. Since the built-in convention for Eclipse is to use .internal. as the package name, it would be useful to have a pre-defined filter (like 'Empty Packages' and 'Folders containing no packages') defined to hide internal packages (which should not be selected by default, obviously).

Although there is a workaround (you can type in *.internal.* in the name filter at the top) this is a common naming convention and may benefit from having a simple select checkbox.

I suggest this be added with 'helpwanted' to encourage contribution.
Comment 1 Dani Megert CLA 2012-10-17 03:31:05 EDT 
I'm against hard-coding the *.internal.* pattern. The correct approach here is to hide things based on the access restrictions which Eclipse already sets on the libraries when using PDE and which each project can define by itself. By default those are set to 'discouraged' for internal Eclipse dependencies and not hidden but you can simply change this on the 'Type Filters' preference page. Unfortunately this does currently not work for 'Open Type' (see bug 392135).

Now, of course this does not yet solve your problem. What we need is a view filter (org.eclipse.jdt.ui.javaElementFilters)that applies the 'Type Filters' on the view. This filter would be added to all our JDT views (Package Explorer, Packages view, Types view etc.).