Bug 391948 - Incremental Find doesn't handle Enter correctly
Summary: Incremental Find doesn't handle Enter correctly
Status: RESOLVED WORKSFORME
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2012-10-15 12:07 EDT by Mark Macdonald CLA
Modified: 2013-10-03 10:31 EDT (History)
2 users (show)

See Also:
jparks: review?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2012-10-15 12:07:46 EDT 
1. Open editor on a file
2. Press Ctrl+J and type in a term that appears in the file.
3. The match is highlighted and status line shows:
> Incremental find: var
4. Now press Enter. The incremental find appears to search for an actual newline as part of your search term, and you see:
> Incremental find: var_

This is weird. I expected Enter to cancel incremental find (as in Eclipse desktop). Another acceptable alternative would be for Enter to go to the next match.
Comment 1 Josh Parks CLA 2012-11-20 15:39:31 EST 
GitHub URL: https://github.com/jparks06/orion.client.git
Branch: Bug391948
Commit ID: 1f8103504fd1c50b378788ca177daa45939c96ae

Altered the "enter" function for the Incremental Find feature. Now hitting 'enter' cancels out of the search and returns to the regular editor.
Comment 2 Silenio Quarti CLA 2013-10-03 10:31:57 EDT 
This has been fixed for a while (Orion 3.0 and greater)