Bug 391942 - "c o n t a i n e r t h e m e" appearing on console on theme settings page
Summary: "c o n t a i n e r t h e m e" appearing on console on theme settings page
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 1.0 RC3   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-15 11:24 EDT by John Arthorne CLA
Modified: 2012-10-15 14:57 EDT (History)
2 users (show)

See Also:
john.arthorne: review? (antonm)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2012-10-15 11:24:50 EDT 
I20121015-0953

Every time I visit the theme settings page, I see this in the log:

c o n t a i n e r   t h e m e

It should be removed as it just clutters the console

This comes from line 296 of ThemeData.js. 

  console.log( 'c o n t a i n e r   t h e m e' );
Comment 1 John Arthorne CLA 2012-10-15 11:26:05 EDT 
1.0 candidate?
Comment 2 Ken Walker CLA 2012-10-15 11:37:12 EDT 
s o u n d s  g o o d  t o  m e
Comment 3 John Arthorne CLA 2012-10-15 14:56:09 EDT 
Don't think this warrants a big review, but Anton please take a glance at the commit:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e995a0e17aa546aba042a1515271356fa1ae4e97
Comment 4 John Arthorne CLA 2012-10-15 14:57:22 EDT 
I noticed the other copy of ThemeData.js also has some console logging, but it only seems to happen on theme import, so I left it alone. This one is annoying because it happens on every page visit.