Comment 1 Manoj N Palat 2012-11-27 21:03:41 EST

Created attachment 224028 [details]
Proposed Fix

Comment 2 Srikanth Sankaran 2012-11-30 01:11:54 EST

Jay, could you please review and take this to release ? TIA.

Comment 3 Jay Arthanareeswaran 2012-12-10 01:10:33 EST

Manoj, I believe the new JavaCore option needs to be added to the documentation as well. This should go to org.eclipse.jdt.doc.isv/guide/jdt_api_options.htm

You can refer to COMPILER_PB_UNUSED_PARAMETER in the same file.

Comment 4 Manoj N Palat 2012-12-10 04:11:26 EST

Created attachment 224502 [details]
Additional Patch as per review comment 3

This is in addition to the already existing patch.

Comment 5 Manoj N Palat 2012-12-10 08:55:50 EST

Created attachment 224515 [details]
Combined Patch of the two patches

Comment 6 Jay Arthanareeswaran 2012-12-10 09:05:58 EST

(In reply to comment #5)
> Created attachment 224515 [details]
> Combined Patch of the two patches

Something wrong with the patch? The patch has so many lines and the size is too big.

Comment 7 Manoj N Palat 2012-12-10 22:09:02 EST

Created attachment 224540 [details]
Modified combined Patch

Comment 8 Srikanth Sankaran 2012-12-10 23:21:35 EST

(In reply to comment #6)
> (In reply to comment #5)
> > Created attachment 224515 [details]
> > Combined Patch of the two patches
> 
> Something wrong with the patch? The patch has so many lines and the size is
> too big.

Please always look through the patch one time before posting to make sure
there are no extraneous changes etc.

Comment 9 Manoj N Palat 2012-12-14 02:11:56 EST

Created attachment 224708 [details]
Fix

Slight modification in the text message to make it similar to the neighbouring text.

Comment 10 Jay Arthanareeswaran 2012-12-14 03:17:05 EST

Patch looks good.

But moving the bug to M5 since we don't have much time left for M4.

Comment 11 Jay Arthanareeswaran 2013-01-03 01:57:22 EST

Released in master for 4.3 M5

Comment 12 Stephan Herrmann 2013-05-23 09:55:29 EDT

Bug 385780 includes the introduction of a new warning option for the batch compiler,
yet the doc updates misses to update task-using_batch_compiler.htm

IMHO this should be fixed for Kepler.

Comment 13 Jay Arthanareeswaran 2013-05-24 05:21:33 EDT

Manoj, please prepare a patch and keep it ready. We can release it during the RC3 fix pass.

Comment 14 Manoj N Palat 2013-05-27 20:17:36 EDT

Created attachment 231594 [details]
Proposed Patch

Update of task-using_batch_compiler.htm

Comment 15 Markus Keller 2013-05-28 11:41:43 EDT

Fixed bugs in the patch:
- bad formatting: why not split "</tr><tr>" to 2 lines like everywhere else?
- bad table: addition of a -warn sub-option needs an update in rowspan
- bad sorting: options are sorted alphabetically (in the table and in the macro enumeration for "unused")

Then I looked closer at the document and fixed various other bugs as well:
- more bad sorting
- unusedLocal was duplicated -> rowspan back to 100
- bug 409303
- deprecated the wrongly named "unusedArgument" option

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=b351a08612ca6a9b597571c35c962b51ca8c33d3

Comment 16 Jay Arthanareeswaran 2013-05-30 11:12:18 EDT

Verified for 4.3 RC3 with build I20130529-2000