Bug 39108 - Numerous single type imports can slow compiler down significantly
Summary: Numerous single type imports can slow compiler down significantly
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1.2   Edit
Assignee: Kent Johnson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-19 05:25 EDT by Philipe Mulet CLA
Modified: 2003-10-23 07:23 EDT (History)
1 user (show)

See Also:


Attachments
Not really smart but efficient test case (13.28 KB, text/plain)
2003-10-17 13:05 EDT, Frederic Fusier CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2003-06-19 05:25:55 EDT
Build 3.0m1 (also reported in 2.0 stream)

Some client reported that compilation would take a long time in presence of 
large units with numerous single type imports.

A code examination reveals that we could use a cache technique to avoid 
iterating them all when resolving subsequent type references.

Would need to be backported in 2.0 & 2.1 maintenance streams.
Comment 1 Kent Johnson CLA 2003-06-24 12:06:11 EDT
Brian: We need to a 'real' PR to be able to backport this to 2.0.x.
Comment 2 Kent Johnson CLA 2003-08-13 15:25:12 EDT
Backported to 2.1.1 maintenance stream.

Brian: Please connect this PR with whatever one in the other system started the 
process.
Comment 3 David Audel CLA 2003-08-28 06:27:59 EDT
Verified.
Comment 4 Philipe Mulet CLA 2003-09-04 12:44:22 EDT
Candidate for 2.1.2
Comment 5 Frederic Fusier CLA 2003-10-17 13:05:21 EDT
Created attachment 6468 [details]
Not really smart but efficient test case

A real simple class with 182 imports.
Comment 6 Frederic Fusier CLA 2003-10-17 13:05:48 EDT
Verified with build 2.1.2 RC1
Comment 7 Jerome Lanneluc CLA 2003-10-23 07:23:51 EDT
Verified with build 2.1.2 RC2 that single type imports are cached in 
CompilationUnitScope.resolvedSingleTypeImports