Bug 391007 - [egit-github] API Rate Limit Exceeded for <ip>
Summary: [egit-github] API Rate Limit Exceeded for <ip>
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: GitHub (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-03 08:46 EDT by Tomasz Zarna CLA
Modified: 2021-06-15 05:35 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2012-10-03 08:46:12 EDT 
I wasn't doing anything crazy, just refreshed couple of Github queries (issues first then my gists iirc).

org.eclipse.mylyn.internal.github.core.GitHubException: API Rate Limit Exceeded for <ip>
	at org.eclipse.mylyn.internal.github.core.GitHubException.wrap(GitHubException.java:38)
	at org.eclipse.mylyn.internal.github.core.GitHub.createWrappedStatus(GitHub.java:147)
	at org.eclipse.mylyn.internal.github.core.gist.GistConnector.performQuery(GistConnector.java:164)
	at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.synchronizeQuery(SynchronizeQueriesJob.java:311)
	at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.synchronizeQueries(SynchronizeQueriesJob.java:268)
	at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.run(SynchronizeQueriesJob.java:201)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
Caused by: org.eclipse.egit.github.core.client.RequestException: API Rate Limit Exceeded for 87.206.53.174 (403)
	at org.eclipse.egit.github.core.client.GitHubClient.createException(GitHubClient.java:514)
	at org.eclipse.egit.github.core.client.GitHubClient.get(GitHubClient.java:702)
	at org.eclipse.egit.github.core.client.PageIterator.next(PageIterator.java:173)
	at org.eclipse.egit.github.core.service.GitHubService.getAll(GitHubService.java:151)
	at org.eclipse.egit.github.core.service.GistService.getGists(GistService.java:173)
	at org.eclipse.mylyn.internal.github.core.gist.GistConnector.performQuery(GistConnector.java:156)
	... 4 more
Comment 1 Derek Weitzel CLA 2013-03-27 17:37:36 EDT 
I don't believe this is only a mylyn issue.  This is a gihub connector issue.

The Github connector captures but does nothing with the rate limit that Github enforces.  The offending file is on github:
https://github.com/eclipse/egit-github/blob/master/org.eclipse.egit.github.core/src/org/eclipse/egit/github/core/client/GitHubClient.java#L763

The github connector should handle the case where the 'remainingRequests' == 0, and sleep until it can request again (not ideal), or some other clever solution.
Comment 2 Danilo Pianini CLA 2021-06-15 05:35:17 EDT 
At the very least, there should be a "RateLimitService" to let the user manually look into it:
https://docs.github.com/en/rest/reference/rate-limit