Bug 389914 - Strange dialog activation order with multiple detail dialogs from MultiPullResultDialog
Summary: Strange dialog activation order with multiple detail dialogs from MultiPullRe...
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.2-M1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 388667
Blocks:
  Show dependency tree
 
Reported: 2012-09-19 12:26 EDT by Markus Keller CLA
Modified: 2012-09-20 15:55 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2012-09-19 12:26:44 EDT 
Follow-up to https://git.eclipse.org/r/#/c/6490/

Multiple detail dialogs are stacked, and the user expects that when he closes the topmost dialog, then the next in the stack comes to front.

I tried to implement this in org.eclipse.egit.ui.internal.pull.MultiPullResultDialog.
buttonPressed(...).new PullResultDialog() {...}.close(), but this doesn't work reliably because Shell#getShells() is not deterministic (bug 388667).
Comment 1 Markus Keller CLA 2012-09-19 12:31:58 EDT 
Proposed fix: https://git.eclipse.org/r/7834
Comment 2 Matthias Sohn CLA 2012-09-20 15:55:23 EDT 
merged as 334390383c858261dc51d9501c21aa01d2756795