Bug 389473 - CDOTransactionImpl - Objects not deleted after exportChanges -> importChanges
Summary: CDOTransactionImpl - Objects not deleted after exportChanges -> importChanges
Status: REOPENED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.13   Edit
Hardware: PC All
: P3 blocker (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-13 02:58 EDT by Joe Sobeos CLA
Modified: 2020-12-11 10:44 EST (History)
1 user (show)

See Also:

Attachments
Patch (100.81 KB, patch)
2012-09-13 07:23 EDT, Joe Sobeos CLA 		no flags Details | Diff
Patch (100.52 KB, text/plain)
2012-09-14 05:03 EDT, Joe Sobeos CLA 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Sobeos CLA 2012-09-13 02:58:27 EDT 
We export changes on the client side and transform them to the server, where they get committed. Objects marked to get deleted (EcoreUtil.delete(object);) were not deleted on the server side.
Looks like they get lost between export and import.
Please have a look to exportChanges and importChanges in CDOTransactionImpl.
For me detached objects are not handled.

As a result the delted object keeps untouched. I would expect to get an updated cdo_version with a number < 0.

How to reproduce:
- delete an object (EcoreUtil.delete(object);) 
- call CDOTransactionImpl.exportChanges 
- call CDOTransactionImpl.importChanges
-> check cdo_version of the object
Comment 1 Joe Sobeos CLA 2012-09-13 07:23:55 EDT 
Created attachment 221031 [details]
Patch

We tried to patch the bug. Therefore we export detached objects and import them again. We don't know if it is the right way to fix the problem.
Please review the attached file. Especially the importChanges changes.
Comment 2 Joe Sobeos CLA 2012-09-14 05:03:01 EDT 
Created attachment 221073 [details]
Patch

Cleaned up version
Comment 3 Eike Stepper CLA 2012-09-19 09:51:34 EDT 
The file you've attached is not a patch but the complete code of CDOTransactionImpl. I can not use it to see your specific changes. Can you provide me with a real patch?
Comment 4 Eike Stepper CLA 2012-09-19 09:52:48 EDT 
Comment on attachment 221073 [details]
Patch

Not a patch.
Comment 5 Eike Stepper CLA 2012-09-21 01:01:41 EDT 
Moving to the integration branch. Possible fixes can be ported to maintenance later.
Comment 6 Eike Stepper CLA 2012-11-01 07:01:07 EDT 
No activity or ping here for a month. Please reopen this bug if you feel a need.
Comment 7 Joe Sobeos CLA 2012-11-19 04:13:23 EST 
Problem still exists.
Comment 8 Eike Stepper CLA 2013-06-29 12:19:09 EDT 
We'll try to address open problems in 4.3 (master) first and then port fixes back to 4.2.
Comment 9 Eike Stepper CLA 2015-07-14 02:21:37 EDT 
Moving all open bugzillas to 4.5.
Comment 10 Eike Stepper CLA 2016-07-31 01:04:24 EDT 
Moving all unaddressed bugzillas to 4.6.
Comment 11 Eike Stepper CLA 2017-12-28 01:10:17 EST 
Moving all open bugs to 4.7
Comment 12 Eike Stepper CLA 2019-11-08 02:11:54 EST 
Moving all unresolved issues to version 4.8-
Comment 13 Eike Stepper CLA 2019-12-13 12:48:53 EST 
Moving all unresolved issues to version 4.9
Comment 14 Eike Stepper CLA 2020-12-11 10:44:57 EST 
Moving to 4.13.