Bug 389395 - "Link with Editor" doesn't work on Compare editor opened from Git Tree Compare
Summary: "Link with Editor" doesn't work on Compare editor opened from Git Tree Compare
Status: REOPENED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Robin Stocker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 394678
Blocks:
  Show dependency tree
 
Reported: 2012-09-12 07:42 EDT by Nicolas Bros CLA
Modified: 2014-12-10 10:24 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2012-09-12 07:42:53 EDT 
- On an EGit project, do "Compare With > Commit..." and select an old commit
- Open a Compare editor by double-clicking a file from the Git Tree Compare view
- Click on "Link with Editor" in the Package Explorer

Result: the local file is not selected in the workspace

I think I know why: the compare editor shows "Local history: <filename> <date>" for the local file, instead of "Local: <filename>". So, it's probably using the latest version from the local history of the file, instead of the file itself.
And apparently the "Link with Editor" doesn't support that.

When you use "Compare With" directly on a file (instead of the whole project), then the left file shows "Local: <filename>", and the "Link with Editor" works as expected.


Eclipse SDK
Version: 3.8.0
Build id: I20120608-1200
org.eclipse.egit (2.0.0.201206130900-r)
Comment 1 Robin Stocker CLA 2012-10-07 10:01:55 EDT 
Fix pushed to review:

https://git.eclipse.org/r/8075
Comment 3 Matthias Sohn CLA 2012-11-28 18:22:40 EST 
fix was reverted as it caused regressions (bug 393990 and bug 395177)