389247 – [Palettes] the current implementation bypass the command framework which brakes undo/redo

Bug 389247 - [Palettes] the current implementation bypass the command framework which brakes undo/redo

Summary: [Palettes] the current implementation bypass the command framework which brak...

Status:	REOPENED

Alias:	None

Product:	Papyrus
Classification:	Modeling
Component:	Diagram (show other bugs)
Version:	0.10.0
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	M7
Assignee:	Mathieu Velten
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-09-11 08:55 EDT by Mathieu Velten
Modified:	2017-08-03 04:59 EDT (History)
CC List:	4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mathieu Velten

2012-09-11 08:55:39 EDT

Currently the various aspect tools that we can add to a palette entry are doing model modifications in post commit context instead of allowing to provide a command to chain.
This leads to various undo problems.

Comment 1 Mathieu Velten

2012-10-25 07:30:48 EDT

An implementation has been committed some times ago on 0.8.X-EYY, to be backported.

Comment 2 Raphael Faudou

2013-04-02 09:44:31 EDT

will be backported before M7

Comment 3 Mathieu Velten

2013-04-10 07:18:09 EDT

backported, rev 10824.

Comment 4 Camille Letavernier

2013-04-11 08:32:33 EDT

r10824 has introduced 2200 test regressions: https://hudson.eclipse.org/hudson/user/vlorenzo/my-views/view/Papyrus/job/papyrus-trunk-nightly-tests/972/testReport/

Reverted in r10839. Please feel free to resubmit this contribution when the regressions are fixed.

Comment 5 Mathieu Velten

2013-04-11 08:35:16 EDT

Please don't revert like that, it is a pain : I need the hudson tests build if you want me to iterate on the bugs.

Comment 6 Benoit Maggi

2015-01-21 04:02:00 EST

original commits are these ones :

https://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?h=streams/0.8.X-EYY&id=d9a9967168cbf579796e24bb2ff2a850658b1dfb
https://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?h=streams/0.8.X-EYY&id=3afca1e38683739b338aa76109e81bf27f8fecff

We need to check the report on 1.0 and 1.1 before closing the bug