Bug 388695 - [formatter] formatter should not be run when file is on error
Summary: [formatter] formatter should not be run when file is on error
Status: RESOLVED FIXED
Alias: None
Product: LDT
Classification: Tools
Component: LuaDevelopmentTools (show other bugs)
Version: 0.8   Edit
Hardware: PC Windows 7
: P3 enhancement
Target Milestone: 1.2 RC1   Edit
Assignee: Kevin KIN-FOO CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2012-09-03 10:42 EDT by Simon Bernard CLA
Modified: 2014-04-11 09:40 EDT (History)
0 users

See Also:

Attachments
Formatter crahes on ASTs containing error. (6.20 KB, text/plain)
2012-09-26 05:07 EDT, Kevin KIN-FOO CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Bernard CLA 2012-09-03 10:42:17 EDT 
Currently, the formatter is run even if the file is on error. It does nothing because we need a correct file to format but it is already launched.

The editor blinks and there no information to warm the formatter can not be launched.
Comment 1 Kevin KIN-FOO CLA 2012-09-26 04:59:43 EDT 
Fix integrated with ba12d5523c0227e83cebc057c3a04521dc3acc64
Comment 2 Kevin KIN-FOO CLA 2012-09-26 05:07:19 EDT 
Created attachment 221503 [details]
Formatter crahes on ASTs containing error.
Comment 3 Kevin KIN-FOO CLA 2012-09-26 05:07:49 EDT 
I tried the fix, but there are dome details which bothers me.
When user try to format source which contains error(s):
1. The formating does not occur, but there is no user message in the bottom bar.
2. The stack trace indicates that formatter simply crashed trying, it would be better to have it terminating nicely
I joined the stack trace
Comment 4 Simon Bernard CLA 2014-04-11 09:40:08 EDT 
This is fixed in 1.2M2 version.