Community
Participate
Working Groups
rename the paramter of a method fails Log: Sat Jun 09 16:32:14 GMT+02:00 2001 4 org.eclipse.core.runtime 0 Unhandled exception caught in event loop. org.eclipse.jdt.internal.core.refactoring.Assert$AssertionFailedException: assertion failed; at org.eclipse.jdt.internal.core.refactoring.Assert.isTrue(Assert.java:132) at org.eclipse.jdt.internal.core.refactoring.Assert.isTrue(Assert.java:117) at org.eclipse.jdt.internal.core.refactoring.methods.RenameParametersRefactoring.addParameterRenaming(RenameParametersRefactoring.java:209) at org.eclipse.jdt.internal.core.refactoring.methods.RenameParametersRefactoring.createChange(RenameParametersRefactoring.java:192) at org.eclipse.jdt.internal.ui.refactoring.CreateChangeOperation.run(CreateChangeOperation.java:97) at org.eclipse.jdt.internal.ui.refactoring.PerformChangeOperation.run(PerformChangeOperation.java:118) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:266) at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:777) at org.eclipse.jdt.internal.ui.refactoring.RefactoringWizard.performFinish(RefactoringWizard.java:287) at org.eclipse.jdt.internal.ui.refactoring.UserInputWizardPage.performFinish(UserInputWizardPage.java:150) at org.eclipse.jdt.internal.ui.refactoring.RefactoringWizard.performFinish(RefactoringWizard.java:411) at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:619) at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:326) at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:238) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java(Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java(Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:543) at org.eclipse.jdt.internal.ui.refactoring.AbstractOpenRefactoringWizardAction.run(AbstractOpenRefactoringWizardAction.java:60) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:423) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent(ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent(ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent(ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java(Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java(Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java(Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:732) at org.eclipse.core.internal.boot.InternalBootLoader.run(InternalBootLoader.java:815) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:126) at org.eclipse.core.launcher.Main.run(Main.java:408) at org.eclipse.core.launcher.Main.main(Main.java:281) Log: Sat Jun 09 16:32:14 GMT+02:00 2001 4 org.eclipse.core.runtime 0 assertion failed; org.eclipse.jdt.internal.core.refactoring.Assert$AssertionFailedException: assertion failed; at org.eclipse.jdt.internal.core.refactoring.Assert.isTrue(Assert.java:132) at org.eclipse.jdt.internal.core.refactoring.Assert.isTrue(Assert.java:117) at org.eclipse.jdt.internal.core.refactoring.methods.RenameParametersRefactoring.addParameterRenaming(RenameParametersRefactoring.java:209) at org.eclipse.jdt.internal.core.refactoring.methods.RenameParametersRefactoring.createChange(RenameParametersRefactoring.java:192) at org.eclipse.jdt.internal.ui.refactoring.CreateChangeOperation.run(CreateChangeOperation.java:97) at org.eclipse.jdt.internal.ui.refactoring.PerformChangeOperation.run(PerformChangeOperation.java:118) at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:266) at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:777) at org.eclipse.jdt.internal.ui.refactoring.RefactoringWizard.performFinish(RefactoringWizard.java:287) at org.eclipse.jdt.internal.ui.refactoring.UserInputWizardPage.performFinish(UserInputWizardPage.java:150) at org.eclipse.jdt.internal.ui.refactoring.RefactoringWizard.performFinish(RefactoringWizard.java:411) at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:619) at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:326) at org.eclipse.jface.dialogs.Dialog$1.widgetSelected(Dialog.java:238) at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java(Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java(Compiled Code)) at org.eclipse.jface.window.Window.runEventLoop(Window.java(Compiled Code)) at org.eclipse.jface.window.Window.open(Window.java:543) at org.eclipse.jdt.internal.ui.refactoring.AbstractOpenRefactoringWizardAction.run(AbstractOpenRefactoringWizardAction.java:60) at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:423) at org.eclipse.jface.action.ActionContributionItem.handleWidgetEvent(ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent(ActionContributionItem.java(Compiled Code)) at org.eclipse.jface.action.ActionContributionItem$ActionListener.handleEvent(ActionContributionItem.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java(Compiled Code)) at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java(Compiled Code)) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java(Compiled Code)) at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java(Compiled Code)) at org.eclipse.ui.internal.Workbench.run(Workbench.java:732) at org.eclipse.core.internal.boot.InternalBootLoader.run(InternalBootLoader.java:815) at org.eclipse.core.boot.BootLoader.run(BootLoader.java:285) at java.lang.reflect.Method.invoke(Native Method) at org.eclipse.core.launcher.Main.basicRun(Main.java:126) at org.eclipse.core.launcher.Main.run(Main.java:408) at org.eclipse.core.launcher.Main.main(Main.java:281) AK (6/9/01 4:39:49 PM) happens if cu has some kinds of errors no occurrences of the parameter are the found for some reason investigating.. RenameParametersWiazard was missing a checkActivationOnOpen method + for some reason working copy says 'my structure is known' while the cu says 'mine is not' AK (6/9/01 5:20:52 PM) have a fix approved by EG >= 122 DM (6/19/01 10:20:42 AM) Not fixed, still same error. Test Case: 1. JUnit setup 2. Add error to junit.swingui.TestRunner.createUI(String suiteName) Replace JMenuBar after the = with JcMenuBar 3. Rename parameter suiteName (in above method) 4. Click Finish AK (6/19/01 10:36:32 AM) investigating... ok, structure of the cu is known (no syntax errors) and it is properly started to be analyzed however, it does not analyze any type declared in it (well, there's only 1) it has an error so it is not analyzed. it is not analyzed so no references are found - and the assertion says there must be at least one (the parameter is at least declared). weird, a similar scenario works for other cases - put a compile error into ActiveTest and it works it is not really a regression - a different bug. the original was caused by syntax errors and that is fixed. not also that is not really severe - no code is modified. AK (8/15/2001 7:01:35 PM) fixed - compilation errors are detected now and the refactoring not allowed
should show also the resource path
feedback is improved by presenting error context and resource name
PRODUCT VERSION: 0.121
