Bug 388098 - Diagram editor malfunctions if XML contains white space in entity-name tag
Summary: Diagram editor malfunctions if XML contains white space in entity-name tag
Status: RESOLVED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: Diagram Editor (show other bugs)
Version: 3.2   Edit
Hardware: PC Linux
: P3 major (vote)
Target Milestone: 3.3 M3   Edit
Assignee: Project Inbox CLA
QA Contact: Petya Sabeva CLA
URL:
Whiteboard:
Keywords: plan
Depends on:
Blocks:
 
Reported: 2012-08-27 08:06 EDT by Andras Kovi CLA
Modified: 2012-11-05 09:30 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Kovi CLA 2012-08-27 08:06:54 EDT
Corrected errors manually in diagram XML. These were caused by arbitrary editing, renaming in the diagram and the code. (Sequence not reproducible)

The XML was reformatted and long lines with <entity-name> tags were broken into two lines. E.g:
 <entity-name>com.example.my.project.ThisClass<entity-name>
 became:
 <entity-name>com.example.my.project.ThisClass
 <entity-name>

Result:
1. Classes that suffered the "line break" were not visible in the diagram.
2. No errors reported in the problems view.

Possible cause:
 Parsed entity name is not trim()-ed in code and no exact match found in Java code model.
Comment 1 Petya Sabeva CLA 2012-10-03 02:42:34 EDT
Re-targeting for 3.3. M3.
Comment 2 Petya Sabeva CLA 2012-11-05 09:30:12 EST
Fix is committed in R3_2_maintenance branch with the following git commit:

https://git.eclipse.org/c/dali/webtools.dali.git/commit/?h=R3_2_maintenance&id=71786d37ab2c82303e31fdc054026f43fce57154

and is released in the R3_2_maintenance branch with tag v201211050750.

The fix for the master branch is merged with the following git commit:

https://git.eclipse.org/c/dali/webtools.dali.git/commit/?id=82df57e9f4571c518acada76772bc4a43536a3a6

and is released in the master branch with tag v201211051313.