Bug 388054 - Graphiti e4 integration. Graphiti requires org.eclipse.ui as dependency
Summary: Graphiti e4 integration. Graphiti requires org.eclipse.ui as dependency
Status: ASSIGNED
Alias: None
Product: Graphiti
Classification: Modeling
Component: Core (show other bugs)
Version: 0.9.0   Edit
Hardware: All All
: P4 major with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 388214 388220 388225 388211 388213
Blocks: 442482
  Show dependency tree
 
Reported: 2012-08-25 20:33 EDT by Johnny Qin CLA
Modified: 2021-03-12 05:50 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johnny Qin CLA 2012-08-25 20:33:52 EDT
I am using Eclipse Juno release, Build id: 20120614-1722 on Mac OS. The Graphiti version is 0.10.

Seems Graphiti requires org.eclipse.ui as dependency so that it cannot be integrated with e4. (I could be wrong, please feel free to shoot me down)

Here's my observation
1. use Eclipse wizard to create a "plugin project"
2. on the second page of plugin creation wizard, uncheck "Generate an activator ..."
3. on the third page, choose "Plug-in with a Graphiti Editor" as template
4. Press finish.

Check MANIFEST.MF of the created plugin. It already has 3 dependencies, including "org.eclipse.ui" which is apparently not e4-friendly.

my e4 product is feature based, as below.
<features>
      <feature id="my.own.feature" version="1.0.0.qualifier"/>
      <feature id="org.eclipse.e4.rcp"/>
      <feature id="org.eclipse.emf.ecore"/>
      <feature id="org.eclipse.emf.common"/>
      <feature id="org.eclipse.platform"/>
      <feature id="org.eclipse.help"/>
      <feature id="org.eclipse.equinox.p2.core.feature"/>
      <feature id="org.eclipse.equinox.p2.rcp.feature"/>
      <feature id="org.eclipse.equinox.p2.user.ui"/>
      <feature id="org.eclipse.rcp"/>
      <feature id="org.eclipse.equinox.p2.extras.feature"/>
      <feature id="org.eclipse.graphiti.feature"/>
      <feature id="org.eclipse.graphiti.export.feature"/>
      <feature id="org.eclipse.graphiti.feature.tools"/>
      <feature id="org.eclipse.graphiti.sdk.feature"/>
      <feature id="org.eclipse.graphiti.feature.tools.source"/>
      <feature id="org.eclipse.graphiti.feature.examples"/>
      <feature id="org.eclipse.graphiti.feature.examples.source"/>
      <feature id="org.eclipse.graphiti.source.feature"/>
</features>

I of course need to add the created plugin to my.own.feature. After the product is launched inside Eclipse, the Graphiti editor plugin cannot run.

I posted the question at Graphiti forum http://www.eclipse.org/forums/index.php/t/369969/
Can anyone please either confirm this as a bug (ideally provide a possible fix date estimation if possible) or provide any suggestions as a fix or work around?

Thanks a lot!
Johnny
Comment 1 Michael Wenz CLA 2012-08-27 03:35:37 EDT
Will need a closer look...
Comment 2 Michael Wenz CLA 2012-08-28 08:49:47 EDT
There are various issues involved here, I will create separate bugs for.
Comment 3 Michael Wenz CLA 2012-08-28 08:53:41 EDT
New plug-in with Graphiti editor wizard adds not needed dependency to org.eclipse.ui
Comment 4 Michael Wenz CLA 2012-08-28 08:57:38 EDT
Optional dependency to org.eclipse.ui.ide is needed for two imports: https://bugs.eclipse.org/bugs/show_bug.cgi?id=388213
Comment 5 Michael Wenz CLA 2012-08-28 09:03:48 EDT
Dependency to org.eclipse.ui.navigator brings in org.eclipse.ui:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=388214
Comment 6 Michael Wenz CLA 2012-08-28 09:12:16 EDT
Dependency to org.eclipse.ui.views.properties.tabbed brings in org.eclipse.ui:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=388220
Comment 7 Michael Wenz CLA 2012-08-28 09:25:45 EDT
Dependency to org.eclipse.emf.edit.ui brings in org.eclipse.ui:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=388225
Comment 8 Michael Wenz CLA 2012-08-28 09:32:03 EDT
(In reply to comment #0)
> Can anyone please either confirm this as a bug (ideally provide a possible
> fix date estimation if possible) or provide any suggestions as a fix or work
> around?
> 
It is a bug (or rather a set of bugs). Some of them are easy to fix and are already flagged for both Juno (SR1) and Kepler. The rest might require restructuring of Graphiti's UI bundle and feature. I'm not sure if that will fit into the Kepler timeframe.
Even if we have that restructuring ready it might turn out that there are issues with running a GEF editor inside an e4 RCP app.
Comment 9 Michael Wenz CLA 2012-08-29 04:11:30 EDT
Back to inbox, will work on sub topics
Comment 10 Michael Wenz CLA 2012-11-29 10:50:15 EST
The overall topic needs to be moved after the Kepler release, because to get a complete e4 support in Graphiti we will need a GEF version supporting e4; this will come only with GEF4.
Comment 11 Shawn Kleese CLA 2018-01-17 04:34:00 EST
This Bug is a few years old... Is There anything new ?
Comment 12 Michael Wenz CLA 2018-01-17 08:31:29 EST
While GEF4 is available now (already for quite a while) I have to state that there are unfortunatly no news on this topic on Graphiti side.

Michael
Comment 13 Matthias Casjens CLA 2021-03-12 04:26:12 EST
Are there any news on this topic?
Comment 14 Michael Wenz CLA 2021-03-12 05:50:21 EST
Sorry, unfortunately no news on this. And given that I do not have much time to spend on Graphiti, I actually do not see a good chance to work on this.

Michael