Bug 387501 - EGit should pass the same version to compare as it checks out (autocrlf)
Summary: EGit should pass the same version to compare as it checks out (autocrlf)
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Mac OS X
: P3 normal with 1 vote (vote)
Target Milestone: 2.1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-17 14:19 EDT by Robin Rosenberg CLA
Modified: 2013-07-10 00:49 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Rosenberg CLA 2012-08-17 14:19:40 EDT 
Depending on the interpretation, this is the same as Bug 361503. Because
of the wording of that bug, I'll keep the feature request as is.

When passing data from Git (blobs) to the compare editor, and possibly othe
components, we should perform the same transformation as we do when we
perform a checkout, i.e. expand LF to CRLF if core.autocrlf is true.

This removes most, but not all of the needs for abovementionsd enhancement request.
Comment 1 Robin Rosenberg CLA 2012-08-17 15:12:07 EDT 
Pushed for review:
JGit https://git.eclipse.org/r/#/c/7275/
EGit https://git.eclipse.org/r/#/c/7277/
Comment 2 Matthias Sohn CLA 2012-09-01 16:43:21 EDT 
JGit change merged as 0a9e010e14c96d97e902bf3c46ac1487ed6fbc18
EGit change merged as eeccca2e7b46c9dde28c9075b25bdcfe29cad2a5