Community
Participate
Working Groups
Right now, webtools is breaking the Kepler aggregation, since Graphiti is supplying version 10, and we are requiring version 9. We need to either move up to version 10, or remove ourselves from the M1 aggregation.
Carl, I would suggest we remove the Diagram Editor features from the WTP build to avoid this problem for now. I doubt there will be enough time to correct this by Tuesday next week, but if I am wrong, we could try to reintroduce these features. Tran, can you remove the digram editor features from the build ASAP?
(In reply to comment #1) > Tran, can you remove the digram editor features from the build ASAP? Carl, I will work on making changes to the wtpbuilder right away, unless webtools.releng.git is not ready to take changes now.
I have removed the Diagram Editor feature from Kepler builds. The build is ready to be smoke tested. http://build.eclipse.org/webtools/committers/wtp4x-R3.5.0-I/20120819051539/I-3.5.0-20120819051539/ However, the junit tests did not completed, and I will continue to investigate. David and Carl if you recall what can cause the equinox.launcher to fail, please let me know. There is not much info other than the return code, the logs doesn't show anything wrong. I haven't modify wtpbuilder, just releng for kepler. Thanks. /shared/webtools/projectBuilders/wtp4x-R3.5.0-I/webtools.releng/releng.wtpbuilder/distribution/wtp4x.site/build.xml:40: Java returned: 13 Line 40 in wtp4x.site/build.xml, correspond to: <java fork="true" failonerror="true" classname="org.eclipse.equinox.launcher.Main">
That's often a sign the installation its trying to launch is not valid. Missing a prereq, or something. Often "reported" in the .../eclipse/configuration/*.log file. But in this case, not sure its getting that far to try and run the tests. I did a quick peek, and found this message (among others) !SUBENTRY 1 org.eclipse.equinox.p2.artifact.repository 4 1000 2012-08-19 07:23:22.124 425 !MESSAGE No repository found at file:/home/data/httpd/download.eclipse.org/webtools/downloads/drops/R3.4.0/I-3.4.0-20120612174739/repositoryunittests. That might just mean the "comparator reference" needs to be updated? What strikes me as odd is the name/location of the log: /shared/webtools/projects/wtp4x-R3.5.0-I/workdir/I-3.5.0-20120819051539/buildworkspaces/workspace-runAntRunner-/shared/webtools/projectBuilders/wtp4x-R3.5.0-I/webtools.releng/releng.wtpbuilder/distribution/wtp4x.package/createFinalRepo.xml-build/.metadata/.log Looks like it has /shared/webtools/ in there twice. Maybe its always been that way, but thought I'd mention it, in case its a clue. I'm looking in "projects" (where the build happens) so I think the logs/info for the failed build you are talking about is already lost. You'd have to look in .../eclipse/configuration right after the build to see if any log files there. (Don't think they are currently saved anywhere). HTH (a little)
Oh, and as a reminder ... not sure this was ever resolved, but I know Graphiti used to not provide a proper "p2 repository" ... not sure how you all have been getting around that, but you might try, on your own machine, if you can install it (along with other pre-reqs) and see if there's an install conflict that's not obvious.
(In reply to comment #5) Thanks David, we are removing Graphiti from Kepler, so it's not an issue anymore. Hence I was trying to cleanup the Graphiti properties, and that caused the failure in wtp4x.site. I suspect that it's because it's referred inside the php files, even though there is code to test when a feature needs to be included or not. I am not certain of this, but if it's the case we need to correct wtpbuilder so it handles this situation.
One other thing, I have also remove EMF Transaction and Validation because it is only used by Graphiti. But in the dependency script, it is still hard coded to install those bundles for tests.
This is no longer a blocking issue as the diagram editor has temporarily been removed from the build.
(In reply to comment #8) > This is no longer a blocking issue as the diagram editor has temporarily > been removed from the build. And if not in the build, it will have to be disabled in the aggregation file, as I'm sure Carl will remember. I mention it partially because it was disabled for a while (before Graphiti was re-enabled) but I enabled it again after Graphiti was enabled.
OK...I think Petya has made the code changes necessary to move up to Graphiti 0.10, so that just leaves the build related concerns to deal with. I would like to have a stable, working solution to build the Diagram Editor with it's dependencies before we fully enable the Diagram Editor in the build. We have been building the Diagram Editor on extremely precarious footing from the beginning, requiring time consuming and error-prone steps whenever the Graphiti dependency was changed (even for a milestone update). Please see the comments in bug 379273 for the history of this issue. There are several possible solutions to this, including enhancing the WTP build to handle the dependency issues around EMF Validation and EMF Transaction, or to have Graphiti produce a zip distribution. I have entered bug 389344 to address this question/problem and track a resolution. Once this problem has been resolved I think we can safely re-enable the Diagram Editor in the build.
Tran, It seems we can re-enable the Diagram Editor in the 3.5 stream based on Carl's comments in bug 389344. I'm not sure if he wanted to try and get this change into this week's I-Build, but that is probably ambitious at this point, so let's wait until the I-Build is declared this week, unless we hear otherwise.
Fixed in M3
