Bug 387251 - OpenManifestHandler should open manifest for current editor if the active part
Summary: OpenManifestHandler should open manifest for current editor if the active part
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.3 M2   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard: patch
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2012-08-14 18:57 EDT by Brian de Alwis CLA
Modified: 2012-09-10 12:13 EDT (History)
1 user (show)

See Also:

Attachments
Patch to OpenManifestHandler (6.35 KB, patch)
2012-08-14 18:59 EDT, Brian de Alwis CLA 		curtis.windatt.public: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian de Alwis CLA 2012-08-14 18:57:16 EDT 
The org.eclipse.pde.ui.openManifest command is extremely useful.  It would be even better if it could be invoked for the current active editor.
Comment 1 Brian de Alwis CLA 2012-08-14 18:59:29 EDT 
Created attachment 219889 [details]
Patch to OpenManifestHandler

Check if the active part is an editor, and attempt to obtain the corresponding IProject via IAdaptable/AdapterManager.  Most of the patch is re-indentation.
Comment 2 Curtis Windatt CLA 2012-08-31 16:40:36 EDT 
The code changes look good, I will review it for 4.3.
Comment 3 Curtis Windatt CLA 2012-09-10 12:13:25 EDT 
Works great.  I didn't think this would be something I would use, but I actually am finding it quite useful.

Fixed in master:

http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=681416dc20c22431f23e420b4a49d555b305dd38

Thanks Brian.