Community
Participate
Working Groups
The JUnit View already shows a strike-through icon in the tree for each @Ignore'd test. It would be great if hovering over such a test in the tree would pop up a bubble that tells the reason for ignoring, given as a test to the @Ignore annotation. This would allow people to better understand why a test was skipped, without the need to open the source code of the test.
Probably a place where we could try org.eclipse.jface.window.DefaultToolTip (and thereby fix bugs in the infrastructure). The search for the element can be non-trivial and should use the same code as org.eclipse.jdt.internal.junit.ui.OpenTestAction#findElement(IJavaProject, String)
We need to change the wire format to transfer the message from the test VM to the Eclipse VM. I guess the easiest solution is to send the message as first line of the failure trace or as MessageIds.ACTUAL_START/END message. In the serialization code, we should should put the message into the IXMLTags.ATTR_MESSAGE attribute of the <skipped> node, like https://issues.apache.org/bugzilla/show_bug.cgi?id=43969 This should work for ignored tests as well as for tests with an assumption failure.
(In reply to Markus Keller from comment #2) > We need to change the wire format to transfer the message from the test VM > to the Eclipse VM. I guess the easiest solution is to send the message as > first line of the failure trace or as MessageIds.ACTUAL_START/END message. I have implemented @Ignore reason support with change https://git.eclipse.org/r/39533. The reason is sent as part of the start/end message. > In the serialization code, we should should put the message into the > IXMLTags.ATTR_MESSAGE attribute of the <skipped> node, like > https://issues.apache.org/bugzilla/show_bug.cgi?id=43969 The <skipped> node's message is already used for assumption failures, so I am not sure how, or if at all, ignore reason shall be supported here. I have implemented the reason for the <testcase> node though, as an 'ignorereason' attribute next to the 'ignored' attribute.
Any chance that this will be considered for Mars?
Now that my patch has celebrated its first anniversary, is there a chance it will be included in Eclipse Neon? I appreciate any feedback that is more than changing the target milestone for this bug ;)
(In reply to Christian Georgi from comment #5) > Now that my patch has celebrated its first anniversary, is there a chance it > will be included in Eclipse Neon? I appreciate any feedback that is more > than changing the target milestone for this bug ;) I'm sorry Christian. I have to move this to 4.7. Markus is just too busy with other stuff at the moment.
(In reply to Dani Megert from comment #6) > I'm sorry Christian. I have to move this to 4.7. Markus is just too busy > with other stuff at the moment. Well, isn't there anybody else that is able and willing to review this? Is Markus the only active committer in JDT UI?
(In reply to Christian Georgi from comment #7) > (In reply to Dani Megert from comment #6) > > I'm sorry Christian. I have to move this to 4.7. Markus is just too busy > > with other stuff at the moment. > > Well, isn't there anybody else that is able and willing to review this? > Is Markus the only active committer in JDT UI? Markus is most familiar with the JUnit code and hoped to find time at some point. I suggest you ping again during the first 4.7 milestone.
Thanks for the patch, Christian. These are the review comments: 1. This patch handles only the @Ignore reason. But it should also handle the reason/message given in assumption failures (see bug summary). 2. For accessibility, the reason should also be shown in the JUnit view's failure trace (in addition to the tooltip on the test node). 3. The patch doesn't use the recommendations from comment #2. With the above two requests, you could also use these suggestions.
Target can be reassigned when updated patch is received.
