Bug 386393 - performing content assist on an XML file loads the JPA plug-ins even if not JPA faceted
Summary: performing content assist on an XML file loads the JPA plug-ins even if not J...
Status: RESOLVED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: JPA (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Karen Butzke CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-01 10:17 EDT by Karen Butzke CLA
Modified: 2013-01-09 14:03 EST (History)
1 user (show)

See Also:
neil.hauge: review+

Attachments
proposed patch against 3.2 maintenance (1.26 KB, patch)
2013-01-09 13:24 EST, Karen Butzke CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2012-08-01 10:17:11 EDT 
In a JAXB faceted project if you attempt content assist in an XML file you will see the JPA proposals category. We need to do something similar to the fix in bug 345213 for the org.eclipse.wst.sse.ui.completionProposal extension point.

Then the org.eclipse.jpt.jpa.ui.xml.jpaProposalCategory extension in the org.eclipse.jpt.jpa.ui.plugin.xml would add the enablement element.
Comment 1 Karen Butzke CLA 2012-08-01 12:01:34 EDT 
This causes a side-effect of activating the jpa ui and core plugins when using content assist in an xml file in any type of project. This will result in the same issues as https://bugs.eclipse.org/bugs/show_bug.cgi?id=386171. For 3.2.1 we might want to turn off the force plugin activation on the java completion proposal computer if we can't get the underlying problem fixed in time.
Comment 2 Karen Butzke CLA 2013-01-09 13:24:40 EST 
Created attachment 225397 [details]
proposed patch against 3.2 maintenance

This patch against 3.2 mainteance simply changes the xml content assist extensions to not activate the org.eclipse.jpt.jpa.core plug-in. We are doing this to further fix bug 386171.
Comment 3 Karen Butzke CLA 2013-01-09 13:30:47 EST 
I entered bug 397786 to fully fix this problem in 3.3. For maintenance we just want to prevent the jpa plug-in from loading unecessarily.
Comment 4 Neil Hauge CLA 2013-01-09 14:03:22 EST 
Patch pushed to 3.2 maintenance.