Bug 386337 - Light AOP Parser does not support declare-annotation
Summary: Light AOP Parser does not support declare-annotation
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: LTWeaving (show other bugs)
Version: DEVELOPMENT   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 1.7.1   Edit
Assignee: aspectj inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-31 11:53 EDT by Abraham Nevado CLA
Modified: 2012-08-01 11:35 EDT (History)
1 user (show)

See Also:


Attachments
Proposed Patch (2.37 KB, patch)
2012-07-31 11:55 EDT, Abraham Nevado CLA
aclement: iplog+
Details | Diff
before-after-around patch (2.87 KB, patch)
2012-08-01 05:52 EDT, Abraham Nevado CLA
aclement: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Abraham Nevado CLA 2012-07-31 11:53:38 EDT
As default aop.xml parser is not the light version, some new elements have been added (See Bug 375881). Unless the element declare-annotation was not supported by SimpleAopParser.java.

Thanks and regards.
Comment 1 Abraham Nevado CLA 2012-07-31 11:55:59 EDT
Created attachment 219388 [details]
Proposed Patch
Comment 2 Andrew Clement CLA 2012-07-31 13:25:51 EDT
patch applied, thanks!  No new tests so assuming you have tested this...
Comment 3 Abraham Nevado CLA 2012-08-01 05:52:46 EDT
Created attachment 219416 [details]
before-after-around patch

We attach a new patch to support before, after and around elements by Light AOP Parser

sorry for the inconveniences
Comment 4 Andrew Clement CLA 2012-08-01 11:35:06 EDT
second patch applied, thanks!