Comment 1 Ayushman Jain 2012-07-26 06:20:18 EDT

Created attachment 219203 [details]
proposed fix v1.0 + regression tests

Dani, let me know if this patch suffices. The TL_CONSTRUCTOR_START will be set for all of new |, new M| or new Ma| in the case below.

class Main {
   void foo() {
      new |
   }
}

Comment 2 Dani Megert 2012-07-30 06:44:16 EDT

(In reply to comment #1)
> Created attachment 219203 [details] [diff]
> proposed fix v1.0 + regression tests
> 
> Dani, let me know if this patch suffices. The TL_CONSTRUCTOR_START will be
> set for all of new |, new M| or new Ma| in the case below.
> 
> class Main {
>    void foo() {
>       new |
>    }
> }

Yes, if the space between "new" and | stands for any number of whitespace.

Comment 3 Ayushman Jain 2012-07-30 07:20:24 EDT

(In reply to comment #2)
> Yes, if the space between "new" and | stands for any number of whitespace.

Yup. 

Released via commit cfc5eb85d262e7fc676968dac1dbb5e48659f078 and also added a new test to confirm that any number of whitespaces work between new and |

Comment 4 Dani Megert 2012-08-02 10:35:56 EDT

Thanks. Using new API now in jdt.ui (master) and verified that it works.

Comment 5 Srikanth Sankaran 2012-08-06 02:46:56 EDT

The javadoc reads for the new completion context reads

"The completed token is the first token of a constructor." it is better worded
as "The completed token is the first token of a constructor invocation 
expression".

Verified for 4.3 M1 using Build id: I20120805-2000

Comment 6 Ayushman Jain 2012-08-06 05:15:43 EDT

(In reply to comment #5)
> [..]
> "The completed token is the first token of a constructor." it is better
> worded
> as "The completed token is the first token of a constructor invocation 
> expression".

Good point. Fixed via commit 5b4b5a81d63f2a4115a13f4d0d483f456163707a