Bug 385831 - Revise UI testing constants in WidgetUtil
Summary: Revise UI testing constants in WidgetUtil
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: RWT (show other bugs)
Version: 2.0   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 2.3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2012-07-24 05:14 EDT by Ralf Sternberg CLA
Modified: 2014-07-21 08:21 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Sternberg CLA 2012-07-24 05:14:51 EDT 
There are two constants related to custom widget ids in WidgetUtil, both are marked as provisional.

WidgetUtil.ENABLE_UI_TESTS holds the name of a system property that needs to be set to activate custom widget ids. I think this constant doesn't need to be available as a public constant at all as it is not meant to be used in application code. It should be moved to SystemProps, where all other system props reside. Either we make all of them available as API, or none.

WidgetUtil.CUSTOM_WIDGET_ID is used as key in Widget#setData(). we could consider moving them to the class RWT, as we did with CUSTOM_VARIANT. However, I hesitate making the exchangeability of widget ids more prominent. Overriding widget ids involves the risk of assigning a widget id twice, which produces untraceable errors. I think we should first clarify if custom widget ids are still needed for UI tests (which common UI test tools rely on ids?).
Comment 1 Ivan Furnadjiev CLA 2014-07-21 08:21:55 EDT 
With commit 3a6194788b109e9498363d306b0de690b109dff7 WidgetUtil.ENABLE_UI_TESTS has been moved to internal RWTProperties. Custom widget ids are not supported anymore (RAP 3.0+) and constant is removed.