385385 – Selecting outline element leads to a too large comment selection

Bug 385385 - Selecting outline element leads to a too large comment selection

Summary: Selecting outline element leads to a too large comment selection

Status:	RESOLVED FIXED

Alias:	None

Product:	LDT
Classification:	Tools
Component:	LuaDevelopmentTools (show other bugs)
Version:	0.9
Hardware:	PC All

Importance:	P3 normal
Target Milestone:	0.9 M1
Assignee:	Benjamin Cabé
QA Contact:

URL:
Whiteboard:
Keywords:	bugday

Depends on:
Blocks:

Reported:	2012-07-18 05:17 EDT by Kevin KIN-FOO
Modified:	2012-09-26 04:11 EDT (History)
CC List:	1 user (show)

See Also:

Flags:	kkinfoo: review?

Attachments
Screenshot of faulty comment (43.25 KB, image/png) 2012-07-18 05:23 EDT, Kevin KIN-FOO	no flags	Details
Fix (5.58 KB, patch) 2012-08-22 17:47 EDT, Kevin KIN-FOO	no flags	Details \| Diff
mylyn/context/zip (542.69 KB, application/octet-stream) 2012-08-22 17:47 EDT, Kevin KIN-FOO	no flags	Details
mylyn/context/zip (1.25 KB, application/octet-stream) 2012-08-22 17:50 EDT, Kevin KIN-FOO	no flags	Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Kevin KIN-FOO

2012-07-18 05:17:25 EDT

Hi,

I have a file containing following code:

    --- @type t
    return nil

When I select the `t` type, the resulting selection is one character too long.

Comment 1 Kevin KIN-FOO

2012-07-18 05:23:13 EDT

Created attachment 218859 [details]
Screenshot of faulty comment

Comment 2 Kevin KIN-FOO

2012-08-22 17:47:04 EDT

Created attachment 220168 [details]
Fix

Comment 3 Kevin KIN-FOO

2012-08-22 17:47:13 EDT

Created attachment 220169 [details]
mylyn/context/zip

Comment 4 Kevin KIN-FOO

2012-08-22 17:50:15 EDT

Created attachment 220170 [details]
mylyn/context/zip

Comment 5 Kevin KIN-FOO

2012-08-22 17:50:56 EDT

I found a solution, but I wasn't quite satisfied.
I am sending a patch.
So, ugly or not, you tell me.

Comment 6 Kevin KIN-FOO

2012-09-26 04:11:10 EDT

Fixed with 66b189fb984a1e3e4881cdc55a5bb2a8080378b3