Community
Participate
Working Groups
In tracing preference page trace options cannot be modified using keyboard. The attached patch installs a tree cursor and cell activation strategy. Note that space key is used as activation trigger instead of the usual return key. The latter would lead to the page being closed.
Created attachment 218726 [details] Patch
Testing the patch I found a few issues: 1) static imports were added to java 1.5, PDE is still on EE 1.4 2) using local vars instead of method calls seems like a gratuitous change that distracts from the patch, but not a big deal. 3) at least on linux, the patch breaks the cell editors. With it I can no longer click on a cell to open the combo box.
Christian, I can't spend any time trying to fix this up so it doesn't break the cell editors. If you can fix this I'll take another look.
Created attachment 225535 [details] Updated patch
New patch solving the issues from comment 2: 1) According to the bundle's execution environment (1.5) static imports are allowed. For this change I find them particularly useful. But I can remove them if the execution environment is still 1.4. 2) Removed the distracting renames. 3) Cell editors now are activated again on mouse click. Note that space key cannot be used on Linux to activate the cell editor since space is used as default key on Linux (widgetDefaultSelected is called), leading to the editor being deactivated immediately. The patch uses F2 instead, and space on other platforms. Alternatively we can use F2 on all platforms. I tested the patch on Linux, Mac, and Windows.
Fixed in master http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=37ea7f47ae54da3648c7aac7b76f8108bc8cbd34 Thanks Christian. This patch works great. PDE did just move most of its bundles to 1.5. However, the tracing bundles started as 1.5, so I was mistaken in suggesting the static imports were a problem.
