Comment 1 Dani Megert 2012-07-04 04:54:16 EDT

I took a quick look at the package. The problem is that the fix for bug 340977 was only made for the SDK but not for the Platform product, which is used/launched by the package.

Comment 2 Dani Megert 2012-07-04 04:54:47 EDT

The original change for reference:
http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=624dafba89ca9abed4397b97a1fb97b1c1b4e27f

Comment 3 Markus Knauer 2012-07-04 05:09:41 EDT

Thank's for looking into this. The EPP packages are based on the Platform product, but they've got their own plugin_customization.ini. We need to update these files for Juno SR1.

Comment 4 Dani Megert 2012-07-04 05:12:45 EDT

(In reply to comment #3)
> Thank's for looking into this. The EPP packages are based on the Platform
> product, but they've got their own plugin_customization.ini. We need to 
> update these files for Juno SR1.

But I assume, you would expect this setting to be in the product already, right?

Comment 5 Dani Megert 2012-07-04 05:22:09 EDT

Created attachment 218258 [details]
Fix

Comment 6 Dani Megert 2012-07-04 05:22:50 EDT

John, do you agree that we should also put this into the Platform product?

Comment 7 John Arthorne 2012-07-04 09:22:43 EDT

Products don't inherit preferences from each other, so this really needs to be changed in the EPP plugin customization. We could change it in the platform product as well although I'm not sure many people use this product directly.

Comment 8 Markus Knauer 2012-07-04 09:26:38 EDT

Feel free to assign this bug to EPP - RCP package... then I can take care that the required changes are applied to *all* EPP packages.

Comment 9 Dani Megert 2012-07-04 09:43:27 EDT

(In reply to comment #7)
> Products don't inherit preferences from each other, so this really needs to 
> be changed in the EPP plugin customization.

Right, but the package says:
eclipse.product=org.eclipse.platform.ide
Isn't it then using org.eclipse.platform/plugin_customization.ini ?

If not, where is the file that's used? Even if the platform file isn't used, I guess it is used as initial template.

Comment 10 Markus Knauer 2012-08-28 03:41:54 EDT

Moving to EPP.
IMO this should be enabled in *all* packages.

Comment 11 Lars Vogel 2012-08-28 03:49:04 EDT

@Markus: The default is "enabled", so if this is not overriden by packaging it should be the same in all packages.

Comment 12 Lars Vogel 2013-01-15 10:48:23 EST

Is this fixed? How can I test it?

Comment 13 Dani Megert 2013-01-15 10:57:22 EST

(In reply to comment #12)
> Is this fixed? How can I test it?

I guess so. Download the RCP or RAP package. Start with a new workspace and check whether the preference is enabled or not.

Comment 14 Lars Vogel 2013-01-15 10:59:31 EST

Thanks Dani. Can you point me to the download URL for the pre-packaged stuff?

I typically use http://download.eclipse.org/eclipse/downloads/ and I think this does not include the packages.

Comment 15 Dani Megert 2013-01-15 11:00:28 EST

(In reply to comment #14)
> Thanks Dani. Can you point me to the download URL for the pre-packaged stuff?
> 
> I typically use http://download.eclipse.org/eclipse/downloads/ and I think
> this does not include the packages.

http://www.eclipse.org/downloads/

Comment 16 Lars Vogel 2013-01-15 11:15:32 EST

This page does only only the released packages AFAIKS. And I reported this big for them.

What did I overlooked?

Comment 17 Dani Megert 2013-01-15 11:19:59 EST

(In reply to comment #16)
> This page does only only the released packages AFAIKS. And I reported this
> big for them.
> 
> What did I overlooked?

Very prominent at the top, is just below the big 'Eclipse Downloads', there is 'Developer Builds' ;-).

Comment 18 Lars Vogel 2013-01-15 11:21:40 EST

Ups. Thanks Dani, I test this as soon as I have a decent Internet connection.

Comment 19 Lars Vogel 2013-01-16 08:37:05 EST

I tested this and it looks good on the "Eclipse RCP and RAP" package. Thanks!

Comment 20 Dani Megert 2013-01-16 08:45:28 EST

.