Description Scott Pedigo 2012-06-30 12:58:54 EDT

When under Preferences -> Java -> Compiler -> Errors/Warning -> Potential programming problems, the option Potential resource leak is set to Warning or Error, then a warning or error is generated for methods which return an InputStream. Obviously, a method returning an InputStream is not going to want to close the InputStream. In the following sample, the error or warning is reported for the line "return is;" The method _using_ the InputStream is the one where a warning needs to be displayed.

-- Sample Code --

 	/**
	 * Returns an input stream from the specified properties file.
	 * 
	 * @param source String the name of the properties file.
	 * @return InputStream the input stream, or null.
	 */
	private static InputStream getInputStream(String source) {
		boolean logDebugEnabled = LOG.isTraceEnabled();
		if (logDebugEnabled) {
			Object[][] params = {{"source", source}};
			LOG.entering(PropertyUtils.class, "getInputStream", params);
		}
		InputStream is = null;
		try {
			URL url = null;

			// Try retrieving with the class loader.
			if (is == null) {
				try {
					url = PropertyUtils.class.getResource("//" + source);
					if (url != null) {
						is = url.openStream();
					}
				}
				catch (Exception e) {
				}
			}

			// Try retrieving with the system classloader.
			if (is == null) {
				url = ClassLoader.getSystemClassLoader().getResource(source);
				if (url != null) {
					try {
						is = url.openStream();
					}
					catch (IOException e) {
					}
				}
			}

			// Try looking in the file system.
			if (is == null) {
				try {
					is = new FileInputStream(source);
				}
				catch (IOException e) {
				}
			}

			// Return the input stream, if found, otherwise null.
			return is;
		}
		finally {
			if (logDebugEnabled) {
				LOG.exiting(is != null ? "OK" : "not found");
			}
		}
	}
 
-- Configuration Details --
Product: Eclipse 1.5.0.20120131-1544 (org.eclipse.epp.package.jee.product)
Installed Features:
 org.eclipse.jdt 3.8.0.v20120525-1249-8-8nFqlFNOfwKDRGz-pXLdGxEM83