Comment 1 Mickael Istria 2012-08-27 12:15:55 EDT

Created attachment 220346 [details]
Patch

Patch providing support for ISiteBundle and SiteBundleAdapter in Site model, and consuming them in Category editor.

Comment 2 Curtis Windatt 2012-08-31 12:57:12 EDT

Thanks for the patch, I will find some time to review it for 4.3.

Comment 3 Curtis Windatt 2013-01-10 14:42:19 EST

Fixed in master
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=d757ac6bdd72a30d71ad4b82372c084c33757860

The provided patch was incomplete.  It added the bare bones structure for adding bundles but didn't support any of the editor's features.  I added/fixed the following:

Rename bundle to plug-in in the UI
Support copy/cut/paste (there are still problems with paste but no regressions)
Support delete key and remove menu item
Drag and Drop support
Support plug-ins without a category
Open editors on double click
Editing categories needed to update plug-ins
Undo/Redo support
Outline view support
New plug-ins should have category initialized from selection

Comment 4 Dani Megert 2013-01-11 03:15:56 EST

This causes compile warnings in the official builds:

http://download.eclipse.org/eclipse/downloads/drops4/N20130110-2000/compilelogs/plugins/org.eclipse.pde.core_3.9.0.N20130110-2000/@dot.html

http://download.eclipse.org/eclipse/downloads/drops4/N20130110-2000/compilelogs/plugins/org.eclipse.pde.ui_3.8.0.N20130110-2000/@dot.html


Please fix asap.

Comment 5 Mickael Istria 2013-01-11 05:04:49 EST

Thanks Curtis, sorry for the patch being incomplete, I've just made it working minimally did not think about all the features and corner-case of the editor.

Comment 6 Dani Megert 2013-01-11 05:07:41 EST

(In reply to comment #5)
> Thanks Curtis, sorry for the patch being incomplete, I've just made it
> working minimally did not think about all the features and corner-case of
> the editor.

Mickael, could you take a look at the warnings and provide a patch for those?

Comment 7 Curtis Windatt 2013-01-11 11:13:45 EST

Warnings fixed with:
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=84fd361c6133c98504578f5ff609f8ff4a85b745

Comment 8 Dani Megert 2013-01-14 04:13:20 EST

(In reply to comment #7)
> Warnings fixed with:
> http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/
> ?id=84fd361c6133c98504578f5ff609f8ff4a85b745

Verified in N20130113-2000 that the warnings are gone. Thx.