Bug 381862 - Push Commit... dialog blocks user when fetching branches
Summary: Push Commit... dialog blocks user when fetching branches
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.11   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2012-06-06 09:58 EDT by Markus Keller CLA
Modified: 2018-07-24 16:34 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2012-06-06 09:58:41 EDT
In the History view, choose Push Commit... from the context menu and click Next. Now, you can either press Ctrl+Space or start typing a target ref name.

Both ways, you are forced to wait until the remote branches have been fetched in the UI thread. The branches would ideally be fetched in the background. But they should at least be fetched automatically when the wizard page is opened, and not only when it's 100% certain that the fetching will interrupt the user's workflow.
Comment 1 Dani Megert CLA 2012-06-07 03:33:34 EDT
+1
Comment 2 Markus Keller CLA 2012-07-16 14:37:38 EDT
https://git.eclipse.org/r/6801
Comment 3 Mickael Istria CLA 2018-02-09 04:05:04 EST
The goal here is mostly to get rid of the blocking popup. An approach can simply be to run the Fetch Job in background and show some eye-candy.
Either JGit could reimplement some kind of eye-candy (such has a "Loading refs" label beside the text which would disappear when ready), or use a Dialog with Progress Monitor and do the same hack to keep it usable than what's done in the SmartImportDialog.
As I don't think it's so important for user to be able to kill the loading job, I would go for the 1st one which is simpler.
Comment 4 Thomas Wolf CLA 2018-02-09 11:18:37 EST
This content assist can be done fully asynchronously using the same mechanisms as in bug 530685.
Comment 5 Lucas Bullen CLA 2018-07-24 15:58:27 EDT
I believe this issue has been fixed as using I20180308-0630 instead of the UI being blocked I'm seeing a progress monitor on the dialog showing the request being made while I'm still free to type.
Comment 6 Thomas Wolf CLA 2018-07-24 16:34:03 EDT
Good catch. Yes, this was fixed in EGit 4.11 in the "push-branch-wizard" series of commits[1], which made this wizard page use completely asynchronous ref name content assist.

[1] https://git.eclipse.org/r/#/q/topic:push-branch-wizard+(status:open+OR+status:merged)