Bug 381607 - Refreshed marker messages for relocated breakpoints too generalised
Summary: Refreshed marker messages for relocated breakpoints too generalised
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 8.1.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: cdt-debug-inbox@eclipse.org CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2012-06-04 12:52 EDT by Scott Tepavich CLA
Modified: 2020-09-04 15:19 EDT (History)
4 users (show)

See Also:


Attachments
Proposed patch (3.59 KB, patch)
2012-06-04 16:22 EDT, Scott Tepavich CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Tepavich CLA 2012-06-04 12:52:53 EDT
I'm testing with a backend that exercises the ability to relocate source line breakpoints.  CLineBreakpoint has a method for refreshing a marker messages, to include a hint that the breakpoint has been relocated.  The problem is that the message is too generalised.

When multiple breakpoints are relocated to the same line, the tool-tip hover text only displays one marker message for all the breakpoints at that line (since all of the breakpoints have the same formatted message).
Comment 1 Scott Tepavich CLA 2012-06-04 16:22:43 EDT
Created attachment 216793 [details]
Proposed patch

I'm trying to push this change to gerrit for review, but I'm running into permission problems at the moment.  I'm posting the patch here in case something goes wrong.

The proposal changes the marker message for relocated breakpoints, so there is enough variation between multiple marker messages that the text hover does not consolidate them.
Comment 2 Pawel Piech CLA 2012-06-05 00:39:31 EDT
(In reply to comment #1)
> I'm trying to push this change to gerrit for review, but I'm running into
> permission problems at the moment.  I'm posting the patch here in case
> something goes wrong.

Thanks!  I found the patch in gerrit and added comments there.
Comment 3 Jesse Weinstein CLA 2013-06-06 13:47:55 EDT
Patch in gerrit: https://git.eclipse.org/r/6246
Comment 4 Jonah Graham CLA 2019-12-30 17:05:18 EST
This bug was assigned and targeted at a now released milestone. As that milestone has now passed, the milestone field has been cleared. If this bug has been fixed, please set the milestone to the version it was fixed in and marked the bug as resolved.