Bug 381171 - CreateRequest should extend LocationRequest
Summary: CreateRequest should extend LocationRequest
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy GEF (MVC) (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-31 07:33 EDT by Felix Rath CLA
Modified: 2012-06-01 05:39 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Rath CLA 2012-05-31 07:33:40 EDT 
Build Identifier: Version: 3.7.2 Build id: M20120208-0800

The class CreateRequest in the org.eclipse.gef.requests does not extend the LocationRequest class from the same package, instead of subclassing it simply reimplements the whole functionality. I confirmed this in the 3.7_maintenance and master branch of the eclipse git repository aswell.

Reproducible: Always
Comment 1 Alexander Nyßen CLA 2012-06-01 05:39:12 EDT 
Agreed, we could change this. However, as we are passing RC3 today, this will not be included in 3.8.