Bug 381153 - [search] Better advertise search view filter options
Summary: [search] Better advertise search view filter options
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 377508
  Show dependency tree
 
Reported: 2012-05-31 05:28 EDT by Stephan Herrmann CLA
Modified: 2014-06-15 13:44 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2012-05-31 05:28:29 EDT
During discussions in Bug 377508 I just now learned about some options
for filtering search like 'Inexact Type Arguments'.

Firstly, I never noticed this option because much of my time working with
Eclipse the code is Java 1.4 and thus the option isn't offered.
-> had the option been shown but greyed out I might have seen and
   remembered, but by not showing this option I was "convinced" it didn't
   exist at all.

Looking into help I only found one mentioning of this option under
Java development user guide > Eclipse and J2SE 5.0 and scroll down
several pages.
Since the case of migrating to J2SE 5.0 is becoming rare now, I think 
this feature should be explained in a more canonical place like under
Reference > Search

Next this filter seems to be unavailable in the call hierarchy, where
it would add much value actually.

Another option for better advertising such options would be from the
search dialog. It has so many things to chose from, one may get the
impression that this is all you can do for searching - thus missing the
opportunity to add filters after the fact in the search result view.
Comment 1 Markus Keller CLA 2012-05-31 09:12:19 EDT
Good point, I'll add some doc for this to ref-dialog-java-search.htm.

Bug 369379 is for adding these filters to the Call Hierarchy.

The Java Search tab is already overwhelming, so I wouldn't add more text there. But the the Search view already has a description label on top that says "(Filtered)" or "(* matches filtered from view)".

We could also add "(Unfiltered)" in case all filters are disabled and then turn this into a link that opens the Search Filters dialog. Keeping this bug for that.
Comment 2 Stephan Herrmann CLA 2012-05-31 09:33:42 EDT
(In reply to comment #1)
> The Java Search tab is already overwhelming, so I wouldn't add more text there.

I agree on the "overwhelming" part, but maybe the "Limit To" group could
still host a link to another popup selection for filters?
At least this is where I searched in the first place.



On the long run I could think of three groups in a vertical layout:

Search For:

Constraints:
as a tab folder with 2 tabs:
  Limit To: and Filtering:
perhaps even 3 tabs if fine grained locations should be promoted
from popup to their own space

Where:
as a tab folder with 2 tabs:
Search In: and Scope:

But maybe nested tab folders is a bit too wild :-}