Bug 380726 - org.apache.openejb.core can not back packed200'd?
Summary: org.apache.openejb.core can not back packed200'd?
Status: RESOLVED FIXED
Alias: None
Product: Orbit
Classification: Tools
Component: bundles (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P1 blocker (vote)
Target Milestone: Juno RC3   Edit
Assignee: David Williams CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-25 15:54 EDT by David Williams CLA
Modified: 2012-05-26 01:49 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2012-05-25 15:54:33 EDT 
I was doing final verification to make sure all jars were signed (they sometimes fail silently) and noticed this error: 

   org.apache.openejb.core_4.0.0.beta-2_v201205191252.jar.pack.gz:                                               jarsigner: java.lang.SecurityException: SHA1 digest error for org/apache/openejb/toplink/JTATransactionController.class  

 exitcode:  1: org.apache.openejb.core_4.0.0.beta-2_v201205191252.jar.pack.gz 

We've seen a few similar cases, where, for whatever reason, java code isn't correctly "condiditioned" by pack200 and is hard to spot, except it messes up things like unpacking signed files.
Comment 1 David Williams CLA 2012-05-25 15:59:41 EDT 
Lazar, 

Are you "around"? Have an opinion about fixing this for Juno R build? 

Technically, should not be a "blocker", in theory, since p2 can handle bad "pack200" files and "fall back" to the regular jar ... but ... not sure that theory always works :) 

The "cure" is to simply add an eclipse.inf file to the META-INF folder and specify "do not condition". That way, you still end up with a signed jar, but just a jar, untouched by pack200.
Comment 2 David Williams CLA 2012-05-26 01:45:50 EDT 
I have decided we should fix this, and I will now. 

I do no know if it is being used in Juno common repository, but if it was, a bad pack.gz file is one of the things the aggregator would count as an error, and not build the site (or, not include that jar) so it would be blocking in that case, with very few (and difficult) work arounds.). 

Lazar, if you ever really want this file to be pack200'd, you are welcome to investigate deeper ... but, for now we'll choose the option that at least leaves everything in a valid state.
Comment 3 David Williams CLA 2012-05-26 01:49:28 EDT 
Have committed change. Build (and release) should be ready Saturday.