Community
Participate
Working Groups
EclipseLink added annotations and xml metadata for NoSQL support in bug 366426. We need tolerance for this new feature. Currently if a user adds a UuidGenerator annotation or uuid-generator xml element and references it via @GeneratorValue or generated-value, Dali would give a validation error. We also need to tolerate any other xml schema changes EclipseLink made in the eclipselink_orm_2.4.xsd schema
Created attachment 216171 [details] proposed patch against HEAD This patch is large partially because of generated code since there were multiple changes I had to make to the ecore model for the eclipselink-orm 2.4 schema. The other large change was to add support for the new UuidGenerator. This is EclipseLink specific and involves some new provisional API classes, but no changes to existing api
Created attachment 216196 [details] proposed patch against HEAD Updated patch, minor mistake in the ecore model was causing some test failures. All tests pass now.
Created attachment 216199 [details] proposed patch against HEAD attached the wrong patch
Created attachment 216200 [details] orm resource model changes - generated code Splitting up the patch: the first patch is required to tolerate the changes EclipseLink made in the eclipselink_orm_2.4.xsd schema. If we do not support the new changes then it is possible for our tooling to input schema elements in the wrong order causing schema errors. This patch only has changes to the ecore model and the resulting generated code.
Created attachment 216202 [details] changes to support UuidGenerator Splitting up the patch: the second patch includes java support for the UuidGenerator annotation and eclipselink-orm.xml support for the uuid-generator element on entity, entity-mappings, and id. This is necessary to prevent invalid validation messages if the user references a uuid-generator.
Created attachment 216208 [details] lower generator validation error severity This is another option instead of patch 2. This patch just lowers the severity of the validation error for an undefined generator to a warning.
Deferring to SR1. @UUIDGenerator is not commonly used and the severity of the error can be adjusted by the end user.
I checked the first 2 patches in to HEAD, is that what we want to check in for 3.2.1 as well?
Neil and I are leaning towards checking in the first 2 patches, attachment 216200 [details] and attachment 216202 [details] to maintenance for Juno sr1. Holding off for now because of the minor amount of risk involved with changes of this size.
Deferring this until there is a clear need for this tolerance support.
Since the tolerance support is already in head, should we go ahead and mark this as fixed?
Changed the Generator hierarchy, created a DbGenerator interface for SequenceGenerator and TableGenerator to extend. Moved almost all methods from Generator to DbGenerator. The new UuidGenerator interface can now extend Generator. Created JavaDbGenerator, OrmDbGenerator, and DbGeneratorAnnotation interfaces. http://git.eclipse.org/c/dali/webtools.dali.git/commit/?id=8386b88866c694a15ea0d0db7c61b33e36753044 http://git.eclipse.org/c/dali/webtools.dali.git/commit/?id=d5c9d1dc055f3860e393bbc7991b2e3cf2757fd0
