Bug 379673 - [PATCH] Make TCF log show spaces in messages as actual spaces (and not as unprintable characters)TCF
Summary: [PATCH] Make TCF log show spaces in messages as actual spaces (and not as unp...
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: 1.0.0   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-16 07:43 EDT by Vincent Rubiolo CLA
Modified: 2013-06-05 05:16 EDT (History)
1 user (show)

See Also:


Attachments
Patch making the TCF logger show spaces as actual spaces (1.23 KB, patch)
2012-05-16 07:49 EDT, Vincent Rubiolo CLA
mober.at+eclipse: iplog-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Rubiolo CLA 2012-05-16 07:43:43 EDT
Build Identifier: 

This one-liner (based on today's HEAD) allows to have spaces embedded within TCF messages to be shown by the TCF logger as actual spaces and not as unprintable characters. I have found it very useful to improve readability of TCF logs.

Note that the end of string character was also handled that way (i.e shown as a space). Changing it to an "<eos>" string as as to differentiate it from a normal space does not improve readability very much though so I have chosen to leave this previous behavior unchanged.

Reproducible: Always

Steps to Reproduce:
1. Start a TCF agent.
2. Launch a TCF logger on the agent port.
3. Start a TCF client and connect it to the logger.
4. Run TCF commands which have spaces embedded in them or which return such results.
5. The logger will show what goes through the link albeit with spaces shown as non-printable characters (i.e the "this is a message string" will be shown as "this\x20is\x20a\x20message\x20string" which is far less readable).
Comment 1 Vincent Rubiolo CLA 2012-05-16 07:49:09 EDT
Created attachment 215697 [details]
Patch making the TCF logger show spaces as actual spaces
Comment 2 Vincent Rubiolo CLA 2012-05-16 07:55:14 EDT
I have successfully tested the patch with the TCF logger (tcflog) but, as I understand it, it should also apply to the TCF logging features of the agent (as the source targets the TCF proxy redirection layer). I have thus modified the bug title to reflect this.
Comment 3 Eugene Tarassov CLA 2012-05-18 14:03:49 EDT
I have committed the patch.
Thanks!
Comment 4 Martin Oberhuber CLA 2013-05-24 18:45:55 EDT
Comment on attachment 215697 [details]
Patch making the TCF logger show spaces as actual spaces

iplog- since git has the author:

http://git.eclipse.org/c/tcf/org.eclipse.tcf.agent.git/commit/?id=c19df67c818951693cbe9d1286baefd2db58b01b