Bug 379313 - Is it possible to add a warning for having elementId set?
Summary: Is it possible to add a warning for having elementId set?
Status: CLOSED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Thomas Schindl CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 379304 500318
  Show dependency tree
 
Reported: 2012-05-11 16:40 EDT by Oleg Besedin CLA
Modified: 2016-08-26 05:16 EDT (History)
4 users (show)

See Also:

Attachments
Proposed patch (5.55 KB, patch)
2012-07-15 19:49 EDT, Nobody - feel free to take it CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Besedin CLA 2012-05-11 16:40:40 EDT 
Is it possible to add a warning to the model editor to have a warning indicating that elementId is required? See bug 379216 .
Comment 1 Thomas Schindl CLA 2012-05-11 16:41:48 EDT 
I'll take care of this on the weekend
Comment 2 Lars Vogel CLA 2012-05-13 05:14:10 EDT 
Maybe also a Preference setting to turn of the warnings? Default should be warning.
Comment 3 Nobody - feel free to take it CLA 2012-07-15 19:49:37 EDT 
Created attachment 218737 [details]
Proposed patch

Patch making it easy (I overloaded the method so just add the warning) to add a warning based on a decorator on the text widget. I like it as it is not intrusive and still pretty visible. Example of usage in bug 379304 which I will patch shortly.
Comment 4 Nobody - feel free to take it CLA 2012-07-15 19:59:36 EDT 
The Messages part of the patch belongs to bug 379304 (sorry). I worked on both these bugs in one batch and then had to separate the the patches. So bottom line is that this patch goes together with the bug that this bug blocks(i.e bug 379304)
Comment 5 Lars Vogel CLA 2012-07-19 12:51:15 EDT 
Commit 4b66dc67 add the API to show a warning. Closing this bug, we work on the individual icon decorations in other bugs.
Comment 6 Nobody - feel free to take it CLA 2012-07-22 20:37:23 EDT 
@Lars, I am experiencing a glitch in that the cursor goes back to the beginning if you edit a non empty text box (binding context field for example). Can you confirm that?
Comment 7 Lars Vogel CLA 2012-07-24 04:49:17 EDT 
@Sopot, no I can not reproduce.
Comment 8 Erdal Karaca CLA 2016-08-26 03:09:38 EDT 
I do not see a warning icon when having an empty ID field in the editor.
Tried Neon.0.

Should I re-open this bug?
Comment 9 Lars Vogel CLA 2016-08-26 04:02:56 EDT 
(In reply to Erdal Karaca from comment #8)
> Should I re-open this bug?

I suggest to create a new bug (and add a Gerrit patch ;-))