Bug 377039 - [API] Performance - enhancements for synching methods in the Java resource model
Summary: [API] Performance - enhancements for synching methods in the Java resource model
Status: RESOLVED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: JPA (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M7   Edit
Assignee: Karen Butzke CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 370407 375669
  Show dependency tree
 
Reported: 2012-04-17 19:06 EDT by Karen Butzke CLA
Modified: 2012-04-20 17:08 EDT (History)
2 users (show)

See Also:
neil.hauge: pmc_approved? (david_williams)
neil.hauge: pmc_approved? (raghunathan.srinivasan)
neil.hauge: pmc_approved? (naci.dai)
neil.hauge: pmc_approved? (deboer)
neil.hauge: pmc_approved? (neil.hauge)
neil.hauge: pmc_approved? (kaloyan)
cbridgha: pmc_approved+
neil.hauge: review+

Attachments
proposed patch (39.72 KB, patch)
2012-04-17 21:24 EDT, Karen Butzke CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Karen Butzke CLA 2012-04-17 19:06:40 EDT 
bug 370407 brought up some issues with refactoring java files in JPA projects. The problem is particularly severe if the file you rename is in a project that the JPA project depends upon. This bug will attempt to address the part of this issue related to the java resource model.
Comment 1 Karen Butzke CLA 2012-04-17 21:24:49 EDT 
Created attachment 214156 [details]
proposed patch

To fix this bug I made a minor provisional API change to org.eclipse.jpt.common.core.resource.java.JavaResourceMethod. I added intialize(MethodDeclaration) and synchronizeWith(MethodDeclaration). It is highly unlikely that we have adopters implementing JavaResourceMethod. 

The performance improvements are seen in loading projects, refactoring classes, and some of our actions like 'Make Persistent' that touch a lot of java files.
Comment 2 Neil Hauge CLA 2012-04-18 17:29:08 EDT 
Requesting PMC approval for this provisional API change in M7.  The change should not affect adopters, and has been posted to the newsgroup for feedback - http://dev.eclipse.org/mhonarc/lists/dali-dev/msg01302.html.  The change significantly enhances Dali performance on Dali project load and during refactoring.

See comment #1 for more info on the change.
Comment 3 Karen Butzke CLA 2012-04-20 17:08:20 EDT 
checked in for M7