Bug 3770 - Java Preference page needs better grouping (1GERREW)
Summary: Java Preference page needs better grouping (1GERREW)
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Claude Knaus CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 23:00 EDT by Erich Gamma CLA
Modified: 2001-11-13 08:34 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Erich Gamma CLA 2001-10-10 23:00:35 EDT
EG (6/3/2001 1:57:32 PM)
	the Java preference page needs space between the different groups.
	Package view related prefs should come together.
	There should be whitespace before the hierarchy preference setting.

NOTES:
EG (6/4/2001 12:00:42 PM)
	adding white space is work since we are using the preference dialog	
	fields. This is not critcal, but the order of the packages view prefs
	should change.

EG (6/5/2001 9:56:40 AM)
	defer
Comment 1 Martin Aeschlimann CLA 2001-10-16 11:14:00 EDT
moved to 'active'
Comment 2 Erich Gamma CLA 2001-11-10 16:20:53 EST
We need a custom layout that doesn't use fields. Otherwise we don't have enough 
control.
Comment 3 Claude Knaus CLA 2001-11-12 03:41:23 EST
The sole reason for dropping the field editors is a missing space?
Maybe we should have the field editors give us the missing control.
Comment 4 Erich Gamma CLA 2001-11-12 04:00:46 EST
OK, let's not throw them out yet. But then we should do a Spacer Field Editor 
that allows us to insert space. This should be trival. Can you please look into 
this?

I will bring up the field editor issue with the desktop team again.
Comment 5 Claude Knaus CLA 2001-11-12 04:27:14 EST
One goal of having the field editors is to relieve the writer of the preference 
page from having to layout the fields himself and guaranteee a consistent 
layout throughout the preference pages. A 'spacer' would defeat this purpose. 
I'd rather suggest that spacing between groups of field editors should be 
handled transparently by the layout algorithm. I'll look into it to figure out 
if and how this could be done.
Comment 6 Erich Gamma CLA 2001-11-12 05:26:58 EST
The main purpose of FieldEditors is not layout but handling the field logic 
(saving and loading from preferences). Clients should have control over the 
layout of the controls inside a field editor. This was the initial 
implementation, and I want to check with the desktop why this got changed.

Therefore a spacer is OK.

Comment 7 Claude Knaus CLA 2001-11-13 08:34:16 EST
fixed in 20011113