Community
Participate
Working Groups
Eclipse SDK Version: 4.2.0 Build id: I20120315-1300 With focus in a java editor, type alt+shift+B to show in breadcrumb. Now use the tab key to traverse through the breadcrumb. (tab to traverse forwards, and shift+tab to traverse backwards). Notice that the labels and the Show Children "menu buttons" are both traversable. Only one of them should be traversable. (i.e. the user needs to type twice as many tab keys as necessary to traverse the wnole breadcrumb). Another problem with the breadcrumb is that when using a screen reader, the "menu buttons" do not have an accessible name. The "Show Children" tooltip should be used as the name. If these are toolbar buttons, and if they use the JFace ToolbarManager, then this part of the problem may be fixed when bug 375354 is fixed.
(In reply to comment #0) > Eclipse SDK Version: 4.2.0 > Build id: I20120315-1300 > > With focus in a java editor, type alt+shift+B to show in breadcrumb. > Now use the tab key to traverse through the breadcrumb. > (tab to traverse forwards, and shift+tab to traverse backwards). > Notice that the labels and the Show Children "menu buttons" are both > traversable. Only one of them should be traversable. (i.e. the user needs to > type twice as many tab keys as necessary to traverse the wnole breadcrumb). This is as designed and we have no plans to change this: The item and the arrow have different functionality and one of them has a context menu while the other doesn't. For faster navigation you can use Left/Right Arrow. > Another problem with the breadcrumb is that when using a screen reader, the > "menu buttons" do not have an accessible name. The "Show Children" tooltip > should be used as the name. If these are toolbar buttons, and if they use the > JFace ToolbarManager, then this part of the problem may be fixed when bug > 375354 is fixed. Yes, we use ToolBar and ToolBarManager. As mentioned in bug 375354 I'd even expect this being fixed in the SWT layer. *** This bug has been marked as a duplicate of bug 375354 ***
(In reply to comment #1) > The item and the arrow have different functionality and one of them has a > context menu while the other doesn't. They both seem to have a context menu - type space bar when either one has focus - that's why I thought they were redundant. > For faster navigation you can use Left/Right Arrow. Much better - thanks.
(In reply to comment #2) > (In reply to comment #1) > > The item and the arrow have different functionality and one of them has a > > context menu while the other doesn't. > > They both seem to have a context menu - type space bar when either one has > focus - that's why I thought they were redundant. No, that's the content. Try with the right mouse ;-).
(In reply to comment #3) >> They both seem to have a context menu - type space bar when either one has >> focus - that's why I thought they were redundant. > No, that's the content. Try with the right mouse ;-). Ah, yes - context menu. :) Also available with Shift+F10. :) The control still feels overly complicated for the keyboard user. :) The drop-down arrow buttons feel like they should just be decorative, and not functional, because as far as I can tell they don't add any useful function that the labels don't already have. The labels have nicer behavior for the mouse user, too, because if I click on a label to get the children menu and then decide that I don't want to navigate to those children, I can dismiss the menu by simply clicking again on the label (i.e. without moving the mouse at all, just left click again). With the button, the menu has to be dismissed with more effort, either by moving the mouse elsewhere, or by typing ESC.
(In reply to comment #4) > (In reply to comment #3) > >> They both seem to have a context menu - type space bar when either one has > >> focus - that's why I thought they were redundant. > > > No, that's the content. Try with the right mouse ;-). > > Ah, yes - context menu. :) Also available with Shift+F10. :) > > The control still feels overly complicated for the keyboard user. :) > The drop-down arrow buttons feel like they should just be decorative, and not > functional, because as far as I can tell they don't add any useful function > that the labels don't already have. I'm sorry to contradict again. The label shows all elements on the same level (siblings), while the arrow shows the children.
(In reply to comment #5) > The label shows all elements on the same level (siblings), > while the arrow shows the children. But aren't the siblings the same as the parent's children? If I have a breadcrumb that looks like this: 1> AAA 2> BBB 3> CCC Then the dropdown menu for 1> and AAA are the same, and the dropdown menu for 2> and BBB are the same, and the dropdown menu for 3> and CCC are the same. I am unable to find a case where there is a difference. Am I missing something?
(In reply to comment #6) > (In reply to comment #5) > > The label shows all elements on the same level (siblings), > > while the arrow shows the children. > > But aren't the siblings the same as the parent's children? OK, you caught me :-). I guess we could simply jump over the arrows when using the keyboard.
(In reply to comment #7) >OK, you caught me :-). *phew* - I was really starting to wonder what I could be missing. :) > I guess we could simply jump over the arrows when using the keyboard. Actually, it kind of feels redundant even when clicking with the mouse... :)
(In reply to comment #8) > (In reply to comment #7) > >OK, you caught me :-). > > *phew* - I was really starting to wonder what I could be missing. :) > > > I guess we could simply jump over the arrows when using the keyboard. > > Actually, it kind of feels redundant even when clicking with the mouse... :) Yeah, the arrow is more to give you a visual clue and let it look like a breadcrumb.
(In reply to comment #9) > Yeah, the arrow is more to give you a visual clue and let it look like a > breadcrumb. Can we just use a label instead? Or maybe just prepend an arrow image to the other label's image and use a single control for each segment instead of 2 separate controls?
(In reply to comment #10) > (In reply to comment #9) > > Yeah, the arrow is more to give you a visual clue and let it look like a > > breadcrumb. > > Can we just use a label instead? Or maybe just prepend an arrow image to the > other label's image and use a single control for each segment instead of 2 > separate controls? We made many cycles also with the designers when we created this breadcrumb and the current thing is what we came up with. If you find a better solution I'm happy to look at patches but I won't spend time on this. Sorry.
No problem. I suspect there's not many people who use this feature. (What happens if you simply switch the arrow button to a Label? Does it look awful? Is the breadcrumb still fully functional?)
(In reply to comment #12) > No problem. I suspect there's not many people who use this feature. > (What happens if you simply switch the arrow button to a Label? Does it look > awful? Is the breadcrumb still fully functional?) As said I don't plan to spend time on this at the moment and I could only tell by actually trying this out.
What class are the controls created in, and what project do I need to import to get it?
(In reply to comment #14) > What class are the controls created in, and what project do I need to import to > get it? http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/ 'org.eclipse.jdt.ui' project org.eclipse.jdt.internal.ui.javaeditor.breadcrumb package But the code is also copied by Debug (almost 1:1).
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
