Bug 374920 - [preferences] Non-intuitive tab order on editor preferences dialog
Summary: [preferences] Non-intuitive tab order on editor preferences dialog
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.8 M7   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2012-03-21 11:01 EDT by Max Li CLA
Modified: 2012-03-27 04:56 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Li CLA 2012-03-21 11:01:51 EDT 
1. Open preferences.
2. Go to the Editor option.
3. Tab through the various preferences. The Bracket highlighting radio buttons come before any of the checkboxes above them. It should probably be made so it is consistent with the rest of the preference dialogs, i.e. so that the tab order has the higher up controls first.
Comment 1 Deepak Azad CLA 2012-03-21 11:33:06 EDT 
I can reproduce the problem, however I do not see anything wrong in the JDT/UI code.

The radio buttons are new in 3.8 M6, and they are created in org.eclipse.jdt.internal.ui.preferences.JavaEditorAppearanceConfigurationBlock.createAppearancePage(Composite)
Comment 2 Dani Megert CLA 2012-03-21 13:06:57 EDT 
Sorry I missed this when reviewing the code. This is how radio buttons work (see e.g. bug 181660 or bug 324048).

Fixed in master: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=c3edc193ed5031f375bb806aa94001799532594f
Comment 3 Deepak Azad CLA 2012-03-21 13:23:24 EDT 
(In reply to comment #2)
> This is how radio buttons work
> (see e.g. bug 181660 or bug 324048).
Ha! I didn't know that :-)

Thanks Dani!