Bug 374756 - [product] Sort plugin entries in Product Configuration file/editor
Summary: [product] Sort plugin entries in Product Configuration file/editor
Status: RESOLVED WORKSFORME
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.8   Edit
Hardware: All All
: P3 minor with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: helpwanted, investigate
Depends on:
Blocks:
 
Reported: 2012-03-20 09:55 EDT by Henrik Gustafsson CLA
Modified: 2019-09-02 15:07 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Henrik Gustafsson CLA 2012-03-20 09:55:38 EDT
Build Identifier: Version: 3.8.0 Build id: I20120314-1800 (but has been present for as long as I can remember)

This is a smallish thing that has annoyed me for quite some time.

When using the Product Configuration Editor to add or remove dependencies, the updated file will have all <plugin> under <plugins> and <configurations> listed in some pseudo-random order. 

This makes diffs unnecessarily big and code reviews hard.

Preferably the editor should keep the dependency order as close to the already existing order, or at least write the elements sorted using some stable sort.

Reproducible: Always

Steps to Reproduce:
1. Create product file with a number of dependencies
2. Save file.
3. Update and save file
4. Compare the saved files with local history to see humongous diff.
Comment 1 Martin Karpisek CLA 2016-10-15 13:18:47 EDT
tested on 4.7 M3 (I-Build), seems working
plugins are written to .xml sorted by id in both cases of <plugins> and <configurations>, 
also according to code it should be so (Product class uses TreeMap with pluginId as keys, with treemaps's iterator for writing to xml)
Comment 2 Eclipse Genie CLA 2019-01-05 20:32:50 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 3 Lars Vogel CLA 2019-09-02 14:59:26 EDT
This bug has been marked as stalebug a while ago without any further interaction.

If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard flag.
Comment 4 Lars Vogel CLA 2019-09-02 15:07:22 EDT
This bug was marked as stalebug a while ago. Marking as worksforme.

If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard tag.