Bug 374517 - Enabled combobox when project-specific settings disabled
Summary: Enabled combobox when project-specific settings disabled
Status: ASSIGNED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-indexer (show other bugs)
Version: Next   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-16 11:41 EDT by Andrew Overholt CLA
Modified: 2020-09-04 15:27 EDT (History)
4 users (show)

See Also:
angvoz.dev: review-


Attachments
illustrative screenshot (80.94 KB, image/png)
2012-03-16 11:41 EDT, Andrew Overholt CLA
no flags Details
Enable combo box only when project specific (not derived) and fixed config (790 bytes, patch)
2012-03-17 01:18 EDT, Marc-André Laperle CLA
malaperle: iplog-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2012-03-16 11:41:45 EDT
Created attachment 212791 [details]
illustrative screenshot

Under project properties > C/C++ General > Indexer, there is a combobox at the bottom for choosing the build configuration that the indexer should use.  When project-specific settings are disabled, I think this combobox should also be disabled.  I'll attach a screenshot.

This seems to be the same in both Indigo and Juno (at least M5) builds.
Comment 1 Andrew Gvozdev CLA 2012-03-16 16:41:26 EDT
That is how it is intended by design.  This combobox is enabled when option "Use the build configuration specified in the project's indexer settings" is chosen on Indexer Preference page. This is not the best design IMHO, perhaps we can discuss other options in this bug?
Comment 2 Andrew Overholt CLA 2012-03-16 17:17:23 EDT
I see what you mean but the enabled-ness of the radio buttons inside the 'Build configuration for the indexer' box is toggled when the 'Enable project specific settings' checkbox is toggled.  This is what confuses me.
Comment 3 Marc-André Laperle CLA 2012-03-16 19:22:24 EDT
Weird, I can reproduce this on Linux (Ubuntu 11.10) and Mac (10.7) but not on Windows 7.
Comment 4 Marc-André Laperle CLA 2012-03-16 19:25:31 EDT
Scratch that, this is because my workspace setting is "Use active build configuration" in my Windows workspace but not in my other workspaces.
Comment 5 Marc-André Laperle CLA 2012-03-17 01:18:13 EDT
Created attachment 212821 [details]
Enable combo box only when project specific (not derived) and fixed config

This should fix it. Andrew G, would you mind reviewing/testing the tiny patch? I'm not that familiar with this page but it seems like this is how it should behave.
Comment 6 Marc-André Laperle CLA 2012-03-17 01:44:17 EDT
Comment on attachment 212821 [details]
Enable combo box only when project specific (not derived) and fixed config

Fixed patch description.
Comment 7 Andrew Gvozdev CLA 2012-03-19 18:49:31 EDT
(In reply to comment #6)
> Comment on attachment 212821 [details]
> Enable combo box only when project specific (not derived) and fixed config
> Fixed patch description.
After your patch, how one would use preference "Build configuration for the indexer", especially the second choice? That build configuration will be hardcoded and not changeable anymore?
Comment 8 Marc-André Laperle CLA 2012-03-19 19:07:46 EDT
Comment on attachment 212821 [details]
Enable combo box only when project specific (not derived) and fixed config

(In reply to comment #7)
> (In reply to comment #6)
> > Comment on attachment 212821 [details]
> > Enable combo box only when project specific (not derived) and fixed config
> > Fixed patch description.
> After your patch, how one would use preference "Build configuration for the
> indexer", especially the second choice? That build configuration will be
> hardcoded and not changeable anymore?

You're right. That would force the user to tick "Enable project specific" even though it doesn't override anything. It works as intended. It is a bit confusing though.
Comment 9 Nathan Ridge CLA 2014-04-28 01:51:19 EDT
(In reply to Marc-Andre Laperle from comment #8)
> It works as intended. It is a bit confusing though.

Is there anything still to be done for this bug, or can we close it?
Comment 10 Marc-André Laperle CLA 2014-04-28 08:34:11 EDT
(In reply to Nathan Ridge from comment #9)
> (In reply to Marc-Andre Laperle from comment #8)
> > It works as intended. It is a bit confusing though.
> 
> Is there anything still to be done for this bug, or can we close it?

I think it wasn't closed because it would be nice to improve the UI so that it's less confusing.
Comment 11 Andrew Overholt CLA 2014-04-28 14:51:07 EDT
(In reply to Marc-Andre Laperle from comment #10)
> (In reply to Nathan Ridge from comment #9)
> > (In reply to Marc-Andre Laperle from comment #8)
> > > It works as intended. It is a bit confusing though.
> > 
> > Is there anything still to be done for this bug, or can we close it?
> 
> I think it wasn't closed because it would be nice to improve the UI so that
> it's less confusing.

Should we open a new bug for that?  I haven't personally verified but it seems the original bug has been fixed here.