Bug 373344 - showView doesn't accept secondaryId and secondaryId not defined in IWorkbenchCommandConstants
Summary: showView doesn't accept secondaryId and secondaryId not defined in IWorkbench...
Status: ASSIGNED
Alias: None
Product: RAP
Classification: RT
Component: Workbench (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-06 05:37 EST by Andreas Fischl CLA
Modified: 2012-10-03 07:58 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Fischl CLA 2012-03-06 05:37:35 EST 
Build Identifier: 20110916-0149

The openView command (see plugin.xml of org.eclipse.ui) is missing the secondaryID parameter in the RAP version.

Besides, the constant VIEWS_SHOW_VIEW_SECONDARY_ID which defines "org.eclipse.ui.views.showView.secondaryId" is missing in the RAP version of the class IWorkbenchCommandConstants.

However, the "openView" method on the workbench page handles the secondaryId argument fine (it is even used successfully in the RAP Mail).

Reproducible: Always
Comment 1 Ivan Furnadjiev CLA 2012-10-02 10:01:57 EDT 
Actually the command is "showView". Here is a snippet from the original org.eclipse.ui plugin.xml where the optional "org.eclipse.ui.views.showView.secondaryId" parameter is present:
<command
  name="%command.showView.name"
  description="%command.showView.description"
  categoryId="org.eclipse.ui.category.views"
  id="org.eclipse.ui.views.showView"
  defaultHandler="org.eclipse.ui.handlers.ShowViewHandler">
  <commandParameter
  	 id="org.eclipse.ui.views.showView.viewId"
  	 name="%command.showView.viewIdParameter"
     values="org.eclipse.ui.internal.registry.ViewParameterValues" />
  <commandParameter
     id="org.eclipse.ui.views.showView.secondaryId"
     name="%command.showView.secondaryIdParameter"
     optional="true"/>
  <commandParameter
     id="org.eclipse.ui.views.showView.makeFast"
     name="%command.showView.makeFastParameter"
     optional="true"/>
</command>
Comment 2 Andreas Fischl CLA 2012-10-03 07:58:06 EDT 
Sorry, I meant of course "showView".

And the snippet you pasted is the one from RCP. Here's the corresponding one from RAP:

      <command
      		name="%command.showView.name"
      		description="%command.showView.description"
      		categoryId="org.eclipse.ui.category.views"
      		id="org.eclipse.ui.views.showView"
      		defaultHandler="org.eclipse.ui.handlers.ShowViewHandler">
      		<commandParameter
      			id="org.eclipse.ui.views.showView.viewId"
      			name="%command.showView.viewIdParameter"
      			values="org.eclipse.ui.internal.registry.ViewParameterValues" />
        <commandParameter
              id="org.eclipse.ui.views.showView.makeFast"
              name="%command.showView.makeFastParameter"
              optional="true">
        </commandParameter>
      </command>

Note that org.eclipse.ui.views.showView.secondaryId is missing.